-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String length validation (fixes merge conflicts) #3341
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto FOCONIS-string-length-validation
At deploy time derive a BindMaxLength property to use per BeanProperty
rbygrave
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I'll check those couple of things noted and then we can merge it in.
ebean-core/src/main/java/io/ebeaninternal/server/deploy/BindMaxLength.java
Show resolved
Hide resolved
ebean-core/src/main/java/io/ebeaninternal/server/deploy/meta/DeployBeanProperty.java
Show resolved
Hide resolved
rbygrave
added a commit
that referenced
this pull request
Feb 27, 2024
commit 20152e16891582f8ff466a93ec2cf01871824d6d Author: Rob Bygrave <[email protected]> Date: Tue Feb 27 20:59:51 2024 +1300 #3341 Update DatabaseConfig for fluid style + javadoc commit 1c495a7 Author: Roland Praml <[email protected]> Date: Mon Feb 26 10:25:42 2024 +0100 Fix: Compile errors commit 574876b Merge: df7b048 77634fc Author: Roland Praml <[email protected]> Date: Fri Feb 23 16:16:39 2024 +0100 Merge branch 'master-rob' into FOCONIS-string-length-validation commit df7b048 Author: Rob Bygrave <[email protected]> Date: Mon Jun 26 21:16:32 2023 +1200 #3121 BindMaxLength validation At deploy time derive a BindMaxLength property to use per BeanProperty commit 4683877 Merge: 9a4b9d4 d0020ab Author: Rob Bygrave <[email protected]> Date: Fri Jun 23 16:51:34 2023 +1200 Merge branch 'string-length-validation' of github.com:FOCONIS/ebean into FOCONIS-string-length-validation commit d0020ab Author: Roland Praml <[email protected]> Date: Tue Jun 20 14:47:20 2023 +0200 Length validation less invasive commit 9b3b8ad Author: Roland Praml <[email protected]> Date: Tue Jun 20 13:03:04 2023 +0200 extended DataBind, so that it could return the last bound object commit ca3c02b Author: Roland Praml <[email protected]> Date: Mon Jun 19 09:52:52 2023 +0200 Failing test for SqlServer
Merged via 11c9bdf |
Ok, we can close this as merged via the squashed shown commit above. |
rbygrave
added a commit
that referenced
this pull request
Mar 1, 2024
rbygrave
added a commit
that referenced
this pull request
Mar 1, 2024
rbygrave
added a commit
that referenced
this pull request
Mar 1, 2024
#3341 String length validation with Postgres PGobject (JSON/JSONB)
rPraml
pushed a commit
to FOCONIS/ebean
that referenced
this pull request
Jul 8, 2024
rPraml
pushed a commit
to FOCONIS/ebean
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Rob,
I could not update #3121,
so this PR should fix merge conflicts and compile errors in #3121. Maybe you mege it back.
Roland