FIX: TypeManager initialization fails, if Jackson is not on class path #3149
Conversation
| if (mapper.markerAnnotation() != null) { | ||
| return mapper; | ||
| } else { | ||
| log.log(System.Logger.Level.WARNING, "Not using {0}, because markerAnnotation is null", mapper.getClass().getName()); |
There was a problem hiding this comment.
I think a better message would be to simply say that Jackson is missing on class path. Nobody knows what "markerAnnotation is null" actually means.
There was a problem hiding this comment.
@jnehlmeier thanks for feedback. Do you think this message is OK now? While there isn't an alternative to jackson at the moment, I didn't want to refer to it too directly. See #2564
There was a problem hiding this comment.
I think I would keep it specific as long as only a single implementation is supported. Alternative would be a link to documentation but I think there is no page that describes json configuration for ebean.
… is not on class path
The better fix is to include Jackson on the class path as a dependency of |
|
@rbygrave yes, adding jackson to ebean-jackson-mapper would also be an acceptable solution for me. |
|
This PR - #3250 ... includes Jackson-core and Jackson-databind as transitive dependencies. |
|
I think that means we should close this issue. I'll close it, re-open if needed. |
If
ebean-jackson-mapperbut no jackson is on classpath, it can happen, that the service-loader finds theScalarJsonJacksonMapperclass, and ebean thinks, there is a jsonMapper, but when trying to calljsonMapper.markerAnnotation()you'll get aNoClassDefFoundErrorThis PR checks on initialization, if the markerAnnotation is accessible.