Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image resolution is incorrect with latest ESP IDE release #98

Closed
bernardodesousa opened this issue Mar 26, 2021 · 6 comments
Closed

Image resolution is incorrect with latest ESP IDE release #98

bernardodesousa opened this issue Mar 26, 2021 · 6 comments
Assignees
Labels
blocker Do this before other stuff bug Something isn't working

Comments

@bernardodesousa
Copy link

Great initiative, @easytarget!

Regardless of the resolution set on the controls, ffmpeg always sees the resolution 480x320 in the metadata of the stream.

Screenshot from 2021-03-26 08-16-00

Is anyone else observing this?

@rolfie23
Copy link

rolfie23 commented Apr 24, 2021

Yes, the showed resolution is always 2 steps lower.
UXGA (16001200) outputs a stream of 1024768
SXGA (12801024) outputs a stream of 800608

and so on....
Is there any explanation and solution for it?

I use the page without /stream because the other page you use is an iframe for my idea.

@rolfie23
Copy link

It has something to do with the DCW button. I had it off, switching resolutions shows above problem. Switching DCW button on and of you have the righ resolution.

@giorge1
Copy link

giorge1 commented Apr 25, 2021

I don't know if this might be related to the same problem i had, but it seems that espressif added other resolutions, changing the enumeration definition of the resolutions. The GUI in this repo is using the old framesize enum, hence, when you select SVGA, it will select a different (lower) resolution. This may be the casue of your problem.
To solve this, you could:

  <option value="13">UXGA(1600x1200)</option>
  <option value="12">SXGA(1280x1024)</option>
  <option value="10">XGA(1024x768)</option>
  <option value="9">SVGA(800x600)</option>
  <option value="8">VGA(640x480)</option>
  <option value="6">CIF(400x296)</option>
  <option value="5">QVGA(320x240)</option>
  <option value="3">HQVGA(240x176)</option>
  <option value="1">QQVGA(160x120)</option> 

This might not be the optimal solution, since future changes will cause the same problem.

@easytarget
Copy link
Owner

easytarget commented Apr 30, 2021

@giorge1 👍 Thankyou, I hadn't seen that. 👀

I did check everything compiles and updates with the 1.0.6 expressif release, and I even scrolled through the release notes(*) but this failed to catch my attention.

I suspect the fix is trivial. I'll have a look once my desktop has recovered from the trauma of a Fedora34 upgrade (Hey mom! I broke Esptool and platformIO in one go!).

(*) Ok, they call it the release notes, I call it a non-triaged changelog. I have been a release manager for a number of embedded projects, I have opinions about this..

@easytarget
Copy link
Owner

easytarget commented Apr 30, 2021

This might not be the optimal solution, since future changes will cause the same problem.

There are a number of controls that are currently passed between the WebUI and server as numeric values, when it would be better to pass them as enums, the 'future proof' fix is to pass and store FRAMESIZE_QVGA etc..

.. but I have never gotten around to figuring that out, debugging, testing and then changing the relevent key/value pairs.

@easytarget easytarget self-assigned this Apr 30, 2021
@easytarget easytarget added blocker Do this before other stuff bug Something isn't working labels Apr 30, 2021
@easytarget easytarget changed the title Wrong resolution in metadata Image resolution is incorrect with latest ESP IDE release May 2, 2021
easytarget added a commit that referenced this issue May 3, 2021
* #98 : Fix the framesize list for latest ESP IDE
* Add framesize info to API doc
* Dont use ESP-IDE HEAD for travis, use target version instead (currently 1.0.6)
@easytarget
Copy link
Owner

easytarget commented May 3, 2021

Fixed for all the viewers.

I also took the opportunity to add some new frame sizes; a 96x96 thumbnail, 480x320 HVGA, 1280x720 HD and, for 3MP+ camera modules, 1920x1080 FHD.

I also updated Docs and default config with the new values.

I'm going to do a 3.1 release for this, and fix up install documentaion at the same time.

easytarget added a commit that referenced this issue May 11, 2021
)

* Update UI to allow face detection enabling for CIF mode
Unexpected consequence of the changes addressed in #98 
* Changed the UI labelling for the 'quality' slider to just say 'High (slow)' and 'Low (fast)', much more comprehensible, thanks @TungstenE2
I also allow the slider to go to '6' instead of '10' for the OV2640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Do this before other stuff bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants