Skip to content

Commit

Permalink
No need to pass the version to the deploy script anymore
Browse files Browse the repository at this point in the history
  • Loading branch information
Henri Tremblay authored and Henri Tremblay committed Mar 22, 2021
1 parent 9b610f5 commit 374fcc0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ echo "</ul>"
```

* Launch an Android device (virtual or physical)
* Launch `./deploy.sh version`
* Launch `./deploy.sh`
* Answer the questions (normally, just acknowledge the proposed default)
* Follow the instructions

Expand Down
13 changes: 0 additions & 13 deletions deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,6 @@ function pause {
read -p "Press [enter] to continue"
}

# make sure the version is passed in parameter
if [ "$1" == "" ]; then
echo "Version to deploy should be provided"
exit 1
fi

version=$1

if [ "$(git branch | grep ${version})" == "${version}" ]; then
echo "A branch named $version clashes with the version tag"
exit 1
fi

# Weird fix required by GPG. See https://github.com/keybase/keybase-issues/issues/1712. You will have to enter the passphrase on screen
export GPG_TTY=$(tty)

Expand Down

0 comments on commit 374fcc0

Please sign in to comment.