Skip to content

filter out NVHPC toolchains that share name from the toolchain hierarchy #5140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocaisa merged 2 commits into from
Mar 5, 2026
Merged

filter out NVHPC toolchains that share name from the toolchain hierarchy #5140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99e092c
filter out NVHPC toolchains that share name from the toolchain hirearchy
lexming Feb 25, 2026
b54a2f9
use LooseVersion on both sides of version comparison
lexming Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions easybuild/framework/easyconfig/easyconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,18 @@ def get_toolchain_hierarchy(parent_toolchain, incl_capabilities=False):
"""
# obtain list of all possible subtoolchains
_, all_tc_classes = search_toolchain('')

# Stopgap solution until deprecated compiler-only NVHPC toolchain is removed
# Both the new and old NVHPC toolchains share the same name, we need to
# selectively filter one out based on the version of the toolchain
# TODO: delete with EasyBuild 6.0
if parent_toolchain['name'] == "NVHPC":
wrong_nvhpc_tc_class_name = "NVHPCToolchain"
if LooseVersion(parent_toolchain['version']) < LooseVersion('25.0'):
wrong_nvhpc_tc_class_name = "NVHPC"
wrong_nvhpc_tc_class = [tc for tc in all_tc_classes if tc.__name__ == wrong_nvhpc_tc_class_name]
all_tc_classes = set(all_tc_classes) - set(wrong_nvhpc_tc_class)

subtoolchains = {tc_class.NAME: getattr(tc_class, 'SUBTOOLCHAIN', None) for tc_class in all_tc_classes}
optional_toolchains = {tc_class.NAME for tc_class in all_tc_classes if getattr(tc_class, 'OPTIONAL', False)}
composite_toolchains = {tc_class.NAME for tc_class in all_tc_classes if len(tc_class.__bases__) > 1}
Expand Down