Add back easybuild.toolchains.compiler.nvhpc#5089
Add back easybuild.toolchains.compiler.nvhpc#5089lexming merged 6 commits intoeasybuilders:developfrom
easybuild.toolchains.compiler.nvhpc#5089Conversation
`NVHPC` was replaced by `NvidiaCompilers` in EasyBuild 5.2.0 (f1761f8) which is an accidental breaking change. Add it back with a deprecation notice making sure both are equal for now.
Flamefire
force-pushed
the
nvhpc_compat
branch
from
99b3e7a to
ca168b8
Compare
boegel
changed the title
easybuild.toolchains.compiler.nvhpc
|
|
||
| COMPILER_MODULE_NAME = ['nvidia-compilers'] | ||
| # TODO EasyBuild 6.0: Remove NVHPC name | ||
| COMPILER_MODULE_NAME = ['nvidia-compilers', 'NVHPC'] |
There was a problem hiding this comment.
@Flamefire Hmmm, is this necessary?
Doesn't this mean that the NVHPC module must be available in order to use nvidia-compilers as compiler component in a toolchain?
cc @lexming
There was a problem hiding this comment.
If I understand the code correctly it is an "either". Not fully sure though.
There was a problem hiding this comment.
indeed, this seems more of a convenience attribute in the Compiler class, with no defined purpose. Only real use in framework is to determine the compiler in optarch, which is compatible with this being a list of possible compilers and not all of them:
lexming
left a comment
lexming
left a comment
There was a problem hiding this comment.
I suggest to put some order and more clear comments to the tests, we will forget this very fast.
Co-authored-by: Alex Domingo <alex.domingo.toro@vub.be>
|
Merging, thanks @Flamefire ! |
|
@lexming, @Flamefire this PR likely broke building software with See easybuilders/easybuild-easyconfigs#23755 (comment) |
4 participants
NVHPCwas replaced byNvidiaCompilersin EasyBuild 5.2.0 (f1761f8) which is an accidental breaking change.Add it back with a deprecation notice making sure both are equal for now.