Vendor copy of tomli-w 1.2.0, use it to implement dump_toml function in easybuild.tools.filetools
#5071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
toml-writer
branch
from
03854dc to
0c18712
Compare
1 task
This confuses pylint
Flamefire
force-pushed
the
toml-writer
branch
from
0c18712 to
535119a
Compare
Trigger more code paths of the TOML parser and writer to ensure it works reliably.
Flamefire
force-pushed
the
toml-writer
branch
from
535119a to
1cfea61
Compare
boegel
requested changes
Dec 12, 2025
easybuild/tools/__init__.py
Outdated
| from easybuild.tools.loose_version import LooseVersion # noqa(F401) | ||
|
|
||
|
|
||
| def dump_toml(o: dict) -> str: |
Member
There was a problem hiding this comment.
Please move this to easybuild.tools.filetools, I strongly prefer keeping easybuild.tools largely empty as it is now
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
2 tasks
boegel
changed the title
dump_toml function in easybuild.tools.filetools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
tomllibcan only read TOML files we need a writer too.I decided for
tomli-was it is basically a single file