Skip to content

Add back CI for Python 3.6 by using pyenv#5064

Merged
boegel merged 7 commits intoeasybuilders:developfrom
Flamefire:python3.6
Dec 6, 2025
Merged

Add back CI for Python 3.6 by using pyenv#5064
boegel merged 7 commits intoeasybuilders:developfrom
Flamefire:python3.6

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Dec 3, 2025

As it isn't available with the setup-python action use pyenv to install it.
This allows using any version we need.

This actually turned up an error in our copy_dir method with broken symlinks, similar to https://bugs.python.org/issue6547

@Flamefire Flamefire force-pushed the python3.6 branch 6 times, most recently from 414951f to 1d0d296 Compare December 4, 2025 08:24
@Flamefire Flamefire force-pushed the python3.6 branch 10 times, most recently from e6a68d1 to 905792d Compare December 5, 2025 11:45
As it isn't available with the setup-python action use `pyenv` to
install it.
This allows using any version we need.
Known issue when compiling older (3.6, 3.7) Pythons on recent OS
(likely OpenSSL 3 related).
Use clang as suggested in pyenv/pyenv#2239 (comment)
When setting file attributes after copying with `os.chmod` (internally)
Python 3.6 doesn't handle the case correctly when the OS doesn't support
setting permissions on symlinks (instead of the target files).

In Python 3.7.0 this reports a `NotImplementedError` instead of
`SystemError` which is handled by by `shutil.copytree` (specifically: ignored)
@boegel boegel changed the title Add CI for Python 3.6 Add back CI for Python 3.6 by using pyenv Dec 6, 2025
@boegel boegel added the bug fix label Dec 6, 2025
@boegel boegel added this to the next release (5.2.0) milestone Dec 6, 2025
@boegel boegel added the tests label Dec 6, 2025
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Flamefire Thanks a lot for the effort on this, much appreciated!

@boegel boegel merged commit 9a184b2 into easybuilders:develop Dec 6, 2025
40 checks passed
@Flamefire Flamefire deleted the python3.6 branch December 6, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants