Add required option to EasyConfig.get_cuda_cc_template_value method#4913
Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom Jun 5, 2025
Merged
Conversation
In many places it isn't an error to have no CUDA compute capabilities. Having a parameter to handle this case allows to avoid having to check the EC parameter and the build option in every case causing potential inconsistencies.
get_cuda_cc_template_valuerequired argument to get_cuda_cc_template_value
required argument to get_cuda_cc_template_valuerequired argument to EasyConfig.get_cuda_cc_template_value method
required argument to EasyConfig.get_cuda_cc_template_value methodrequired option to EasyConfig.get_cuda_cc_template_value method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many places it isn't an error to have no CUDA compute capabilities. Having a parameter to handle this case allows to avoid having to check the EC parameter and the build option in every case causing potential inconsistencies.
With this we can do replacements like: