-
Notifications
You must be signed in to change notification settings - Fork 206
Proposed changest to add a timeout
to run_shell_cmd
#4665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Crivella
wants to merge
6
commits into
easybuilders:develop
Choose a base branch
from
Crivella:feature-run_shell_cmd_timeout
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Proposed changest to add a timeout
to run_shell_cmd
#4665
Crivella
wants to merge
6
commits into
easybuilders:develop
from
Crivella:feature-run_shell_cmd_timeout
+114
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebba4d8
to
85f5e44
Compare
I've rebased this on top of the latest 5.0.x and adapted the code to use the changes introduced by #4755 |
85f5e44
to
6df5557
Compare
6df5557
to
7d71efb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes would implement the capability for
run_shell_cmd
to fail after a user-specifiedtimeout
.This would be useful for commands that are known to possibly hang to fail gracefully and report meaningful logs, instead of blocking EB indefinitely.
The PR leverages the already implemented timeout in Popen.communicate (since python 3.3) for non-interactive/streamed usage of
run_shell_cmd
In case of an interactive/streamed run the following has been added:
run.py
read_pipe
: read from a pipe using a thread and raise aTimeoutError
in case the read operation is taking longer than the specified timeoutterminate_process
: attempt to terminate a process gracefully by usingPopen.terminate
first andPopen.kill
after. Raises an EasybuildError if the process is still alive aftertimeout
run_shell_cmd
timeout
timetimeout
timeout