Skip to content

tweak setup.py to fall back to importing setup from setuptools if distutils is not available #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 5 commits into from
Dec 4, 2024
Merged

tweak setup.py to fall back to importing setup from setuptools if distutils is not available #4478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c79ca19
Remove distutils use from setup.py.
bartoldeman Mar 7, 2024
5327191
Appease the hound
bartoldeman Mar 7, 2024
b4c7070
Exclude setup.py from unit test setuptools check.
bartoldeman Mar 7, 2024
7371506
Use distutils if available (in Py 3.11 and under)
bartoldeman Mar 11, 2024
7f960ad
Merge branch '5.0.x' into setup-py-no-distutils
boegel Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ jobs:
run: |
# make sure there are no (top-level) "import setuptools" or "import pkg_resources" statements,
# since EasyBuild should not have a runtime requirement on setuptools
SETUPTOOLS_IMPORTS=$(egrep -RI '^(from|import)[ ]*pkg_resources|^(from|import)[ ]*setuptools' * || true)
SETUPTOOLS_IMPORTS=$(egrep --exclude setup.py -RI '^(from|import)[ ]*pkg_resources|^(from|import)[ ]*setuptools' * || true)
test "x$SETUPTOOLS_IMPORTS" = "x" || (echo "Found setuptools and/or pkg_resources imports in easybuild/:\n${SETUPTOOLS_IMPORTS}" && exit 1)

- name: install sources
Expand Down
17 changes: 10 additions & 7 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,17 @@
##
"""
This script can be used to install easybuild-framework, e.g. using:
easy_install --user .
or
python setup.py --prefix=$HOME/easybuild
python setup.py install --prefix=$HOME/easybuild

@author: Kenneth Hoste (Ghent University)
"""
import glob
import os
from distutils import log
from distutils.core import setup
import logging
try:
from distutils.core import setup
except ImportError:
from setuptools import setup

from easybuild.tools.version import VERSION

Expand All @@ -45,8 +46,10 @@ def read(fname):
return open(os.path.join(os.path.dirname(__file__), fname)).read()


# log levels: 0 = WARN (default), 1 = INFO, 2 = DEBUG
log.set_verbosity(1)
log = logging.getLogger("EasyBuild")

# log levels: NOTSET (default), DEBUG, INFO, WARNING, ERROR, CRITICAL
log.setLevel(logging.INFO)

log.info("Installing version %s (API version %s)" % (VERSION, API_VERSION))

Expand Down