Skip to content

deprecate EasyBuild bootstrap script #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 6 commits into from
Jun 18, 2021
Merged

deprecate EasyBuild bootstrap script #3742

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
80b05b8
point people to other install methods than the boostrap
branfosj Jun 16, 2021
28c9de2
typo
branfosj Jun 16, 2021
b0544c1
Merge branch 'easybuilders:develop' into develop
branfosj Jun 16, 2021
4257628
require that $EASYBUILD_BOOTSTRAP_DEPRECATED is defined to run EasyBu…
boegel Jun 18, 2021
2cea28e
need to unset $EASYBUILD_BOOTSTRAP_DEPRECATED or EasyBuild gets upset…
boegel Jun 18, 2021
8150f1f
Merge pull request #2 from boegel/branfosj_develop
branfosj Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions easybuild/scripts/bootstrap_eb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,8 @@ def main():
self_txt = open(__file__).read()
if IS_PY3:
self_txt = self_txt.encode('utf-8')
info("DEPRECATED: Use of the EasyBuild boostrap script is deprecated and may not work.")
info("Recommended install methods: https://docs.easybuild.io/en/latest/Installation.html\n")

@boegel boegel Jun 18, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would take this one step further, and abort the bootstrap unless an environment variable like $EASYBUILD_BOOTSTRAP_DEPRECATED is defined, to actively discourage still using it.

@boegel boegel Jun 18, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see branfosj#2

info("EasyBuild bootstrap script (version %s, MD5: %s)" % (EB_BOOTSTRAP_VERSION, md5(self_txt).hexdigest()))
info("Found Python %s\n" % '; '.join(sys.version.split('\n')))

Expand Down