add 'rpath' easyconfig parameter to enable use of RPATH regardless of EasyBuild configuration#2283
Open
boegel wants to merge 1 commit intoeasybuilders:developfrom
Open
add 'rpath' easyconfig parameter to enable use of RPATH regardless of EasyBuild configuration#2283boegel wants to merge 1 commit intoeasybuilders:developfrom
boegel wants to merge 1 commit intoeasybuilders:developfrom
Conversation
… EasyBuild configuration
Member
Author
|
An alternate approach could be:
That's probably a better approach... Thoughts @wpoely86, @pescobar, @JackPerdue, @jdonners? |
Contributor
|
"Default" instead of "None" would be less confusing in my opinion but None is easier to code for. |
Contributor
|
@boegel Care to fix the conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have an
rpathtoolchain option that can be used to selectively disable the use of RPATH even if EasyBuild is configured to use RPATH linking via--rpath.In some cases, it may also be interesting to be able to selectively enforce the use of RPATH, regardless of how EasyBuild was configured; see for example easybuilders/easybuild-easyconfigs#4962 (review)
If the
rpatheasyconfig parameter is defined asTrue, RPATH linking is always performed, regardless of the EasyBuild configuration option--rpath.If
--rpathis used, RPATH linking is enabled, unless it's specifically disabled by setting therpathtoolchain option toFalse(Truebeing the default value).After implementing this, which was pretty straightforward, I'm starting to have 2nd thoughts about this approach, since having both an
rpathtoolchain option and easyconfig parameter (on top of the--rpathconfiguration option...) may lead to confusion...