work towards enforcing availability of SHA256 checksums for all sources/patches#2215
Merged
boegel merged 9 commits intoeasybuilders:developfrom May 19, 2017
Merged
work towards enforcing availability of SHA256 checksums for all sources/patches#2215boegel merged 9 commits intoeasybuilders:developfrom
boegel merged 9 commits intoeasybuilders:developfrom
Conversation
…ll sources/patches
Member
|
We could also add the checksums automatically to the archived easyconfig |
Member
Author
|
@ocaisa Sure, but I think that should be done in a separate PR, since that's a bit fiddly (you need to inject Also, there's a bit of chicken-egg situation there, I think, especially if we want to add SHA256 checksums automatically, i.e. they could only be consumed with an EasyBuild version that includes support for (auto-detection of) SHA256 checksums... |
wpoely86
approved these changes
May 11, 2017
Member
|
This PR seems good to me. Nice work |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of changes:
sha256andsha512as checksum types--enforce-checksumsoption to enforce presence of checksums for all sources/patchesIt's a first step towards having SHA256 checksums for all sources/patches in all centrally provided easyconfigs.