{numlib}[GCCcore/8.3.0] GSL v2.5

[cmeesters]

(created using eb --new-pr)

[boegelbot]

Travis test report: 2/2 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/626090158

Only showing partial log for 1st failed test suite run 18853.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/626090160

...
FAIL: test__parse_easyconfig_GSL-2.5-GCCcore-8.3.0.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
Test for parsing of easyconfig GSL-2.5-GCCcore-8.3.0.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 1, in innertest
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 815, in template_easyconfig_test
    self.assertTrue('binutils' in dep_names, "binutils is a build dep in %s: %s" % (spec, dep_names))
AssertionError: binutils is a build dep in /home/travis/build/easybuilders/easybuild-easyconfigs/easybuild/easyconfigs/g/GSL/GSL-2.5-GCCcore-8.3.0.eb: []

======================================================================
FAIL: test_changed_files_pull_request (test.easyconfigs.easyconfigs.EasyConfigTest)
Specific checks only done for the (easyconfig) files that were changed in a pull request.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 713, in test_changed_files_pull_request
    self.check_https(changed_ecs)
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 645, in check_https
    self.assertFalse(failing_checks, '\n'.join(failing_checks))
AssertionError: Found http:// URL in GSL-2.5-GCCcore-8.3.0.eb, should be https:// : http://www.gnu.org/software/gsl/

======================================================================
FAIL: test_style_conformance (test.easyconfigs.styletests.StyleTest)
Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/styletests.py", line 61, in test_style_conformance
    self.assertEqual(result, 0, "Found code style errors (and/or warnings): %s" % result)
AssertionError: Found code style errors (and/or warnings): 1

----------------------------------------------------------------------
Ran 8831 tests in 505.239s

FAILED (failures=3)
ERROR: Not all tests were successful.

• 18853.2 - errored => https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/626090161

*bleep, bloop, I'm just a bot (boegelbot v20180813.01)*Please talk to my owner @boegel if you notice you me acting stupid),or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

[boegelbot]

Travis test report: 2/2 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/626161902

Only showing partial log for 1st failed test suite run 18860.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/626161903

...
FAIL: test__parse_easyconfig_GSL-2.5-GCCcore-8.3.0.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
Test for parsing of easyconfig GSL-2.5-GCCcore-8.3.0.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 1, in innertest
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 815, in template_easyconfig_test
    self.assertTrue('binutils' in dep_names, "binutils is a build dep in %s: %s" % (spec, dep_names))
AssertionError: binutils is a build dep in /home/travis/build/easybuilders/easybuild-easyconfigs/easybuild/easyconfigs/g/GSL/GSL-2.5-GCCcore-8.3.0.eb: []

======================================================================
FAIL: test_changed_files_pull_request (test.easyconfigs.easyconfigs.EasyConfigTest)
Specific checks only done for the (easyconfig) files that were changed in a pull request.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 713, in test_changed_files_pull_request
    self.check_https(changed_ecs)
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 645, in check_https
    self.assertFalse(failing_checks, '\n'.join(failing_checks))
AssertionError: Found http:// URL in GSL-2.5-GCCcore-8.3.0.eb, should be https:// : http://www.gnu.org/software/gsl/

----------------------------------------------------------------------
Ran 8831 tests in 757.785s

FAILED (failures=2)
ERROR: Not all tests were successful.

• 18860.2 - errored => https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/626161904

*bleep, bloop, I'm just a bot (boegelbot v20180813.01)*Please talk to my owner @boegel if you notice you me acting stupid),or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

[cmeesters]

Hi,

This is strange: binutils 2.32 ist NOT a build-dep of this easyconfig. It is an implicit dep in GCCcore 8.3.0, yet this part of eb v 4.0.1 (GCCcore-8.3.0.eb) and in turn satisfied by binutils-2.32-GCCcore-8.3.0.eb

So, why is the test complaining about a missing dependency, one, which is not at all specified by the respective easyconfig, yet should be satisfied by the toolchain?

Best,
Christian

[boegel]

@cmeesters This PR is superseded by the GSL 2.6 easyconfigs in #9504

W.r.t. the binutils in the failing tests: binutils is only a build dep for GCCcore (we use a binutils built with the system compiler to build GCCcore).

When using GCCcore as a toolchain, you should include the binutils build with that GCCcore as a build dependency, that's what the tests are asserting.

In this case however, the GCC bundle (which is just GCCcore+binutils) is a better fit for GSL, which is performance sensitive (so we also install it with iccifort as toolchain).

Using GCCcore as toolchain should only be done for tools that are not performance-sensitive (since then we won't rebuild with Intel compilers if the tool is required as a dependency, but use the build done with GCCcore both for applications built with foss or intel toolchain (or any other that is based on GCCcore).

[boegelbot]

Travis test report: 2/2 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/626175264

Only showing partial log for 1st failed test suite run 18862.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/626175265

...
FAIL: test__parse_easyconfig_GSL-2.5-GCCcore-8.3.0.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
Test for parsing of easyconfig GSL-2.5-GCCcore-8.3.0.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 1, in innertest
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 815, in template_easyconfig_test
    self.assertTrue('binutils' in dep_names, "binutils is a build dep in %s: %s" % (spec, dep_names))
AssertionError: binutils is a build dep in /home/travis/build/easybuilders/easybuild-easyconfigs/easybuild/easyconfigs/g/GSL/GSL-2.5-GCCcore-8.3.0.eb: []

----------------------------------------------------------------------
Ran 8831 tests in 536.717s

FAILED (failures=1)
ERROR: Not all tests were successful.

• 18862.2 - errored => https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/626175266

*bleep, bloop, I'm just a bot (boegelbot v20180813.01)*Please talk to my owner @boegel if you notice you me acting stupid),or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

[cmeesters]

As the pull request is superseeded by the PR for v2.6 (release in August release, which I overlooked), I am closing this PR. Sorry for the effort and thanks for the explanation.