Skip to content

add libXp component to X11 bundle for GCCcore 6.4.0#7062

Merged
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:X11_libXp
Oct 20, 2018
Merged

add libXp component to X11 bundle for GCCcore 6.4.0#7062
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:X11_libXp

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 19, 2018

required for #6266 ...

@boegel boegel added this to the 3.8.0 milestone Oct 19, 2018
@boegel boegel requested a review from vanzod October 19, 2018 16:43
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 19, 2018

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node3106.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/d4c096704b0cc300e30ab63e209931ed for a full test report.

edit: failed because libxcb-1.12_indent.patch patch file could not be found...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 19, 2018

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node3106.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/ec830d72ecde8f3704674d16d702e512 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 19, 2018

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2573.golett.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/ec3f0d5cbb8303c03912a81c5a767483 for a full test report.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Oct 19, 2018

Test report by @vanzod
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
cermis - Linux debian 9.5, Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, Python 2.7.13
See https://gist.github.com/b155d6be5f2bc0bfc46a927a51e01b3e for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 19, 2018

@vanzod This is annoying... The patch isn't found because framework isn't considering the right places. It's usually found right next not the easyconfig file, but not when --from-pr is used since the easyconfig file is downloaded to a temporary location (unless the patch is included in the PR). Ugh.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 19, 2018

OK, after deep diving into this problem, the issue here is actually that there's no approved review yet for the PR, which makes the mergeable_state set to 'blocked' (rather than 'clean').

When a PR is not marked as 'clean', EasyBuild assumes something is wrong with it, and then it resorts to only downloading the files that are touched by the PR.

For clean PRs, it will download current develop and apply the patch corresponding to the PR on top. In that case, the required patch file will be found, even if it's not touched by the PR...

There may be a way to avoid this, but I need to think about it, so I've opened an issue on this in framework, see easybuilders/easybuild-framework#2630

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 19, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2573.golett.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/fd4f5e76b5de72469c10b663f615986a for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 19, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2061.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/ca1d8d6378f563757723a4c1746b0fdd for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 19, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3106.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/1af6e50b469db4dc7e53f7482dbefc7d for a full test report.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Oct 20, 2018

Test report by @vanzod
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
cermis - Linux debian 9.5, Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, Python 2.7.13
See https://gist.github.com/0f7c8ba6ad9c0df907b8d1899bdc050a for a full test report.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Oct 20, 2018

Going in, thanks @boegel!

@vanzod vanzod merged commit fdeb49a into easybuilders:develop Oct 20, 2018
@boegel boegel deleted the X11_libXp branch October 23, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants