Skip to content

{devel}[GCCcore-7.2.0] Doxygen v1.8.14 (with dependencies)#5902

Merged
boegel merged 1 commit intoeasybuilders:developfrom
rdbisme:20180223141731_new_pr_Doxygen1814
Mar 16, 2018
Merged

{devel}[GCCcore-7.2.0] Doxygen v1.8.14 (with dependencies)#5902
boegel merged 1 commit intoeasybuilders:developfrom
rdbisme:20180223141731_new_pr_Doxygen1814

Conversation

@rdbisme
Copy link
Copy Markdown
Contributor

@rdbisme rdbisme commented Feb 23, 2018

(created using eb --new-pr)

@rdbisme
Copy link
Copy Markdown
Contributor Author

rdbisme commented Feb 23, 2018

Test report by @rubendibattista
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
picasso.polytechnique.fr - Linux centos linux 7.4.1708, Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz, Python 2.7.13
See https://gist.github.com/f1011b210ce19c933f850df3e618d1c1 for a full test report.

@boegel boegel added this to the 3.x milestone Feb 25, 2018
@boegel boegel added the update label Feb 25, 2018
boegel
boegel requested changes Feb 25, 2018
View reviewed changes
easybuild/easyconfigs/d/Doxygen/Doxygen-1.8.14-GCC-7.2.0-2.29.eb Outdated
Copy link
Copy Markdown
Member

@boegel boegel Feb 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubendibattista We usually use the GCCcore toolchain for something like Doxygen, so that the resulting module is compatible with both foss and intel (among other toolchains that use GCCcore as a base).

easybuild/easyconfigs/d/Doxygen/Doxygen-1.8.14-GCC-7.2.0-2.29.eb Outdated
Copy link
Copy Markdown
Member

@boegel boegel Feb 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing CMake build dep?

@rdbisme rdbisme force-pushed the 20180223141731_new_pr_Doxygen1814 branch from 92c21e9 to 72cec47 Compare February 26, 2018 14:28
@rdbisme rdbisme changed the title {devel}[GCC/7.2.0-2.29] Doxygen v1.8.14 {devel}[GCCcore-7.2.0] Doxygen v1.8.14 (with dependencies) Feb 26, 2018
@rdbisme
Copy link
Copy Markdown
Contributor Author

rdbisme commented Feb 26, 2018

Test report by @rubendibattista
SUCCESS
Build succeeded for 0 out of 0 (1 easyconfigs in this PR)
picasso.polytechnique.fr - Linux centos linux 7.4.1708, Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz, Python 2.7.13
See https://gist.github.com/b159d2e3819cd5e5afdbb2e0c3b4c72c for a full test report.

@rdbisme
Copy link
Copy Markdown
Contributor Author

rdbisme commented Feb 26, 2018

Test report by @rubendibattista
SUCCESS
Build succeeded for 0 out of 0 (1 easyconfigs in this PR)
picasso.polytechnique.fr - Linux centos linux 7.4.1708, Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz, Python 2.7.13
See https://gist.github.com/360d8b7402f3342b24dfbfbcdfd7f7b1 for a full test report.

@rdbisme
Copy link
Copy Markdown
Contributor Author

rdbisme commented Feb 26, 2018

Test report by @rubendibattista
SUCCESS
Build succeeded for 0 out of 0 (1 easyconfigs in this PR)
picasso.polytechnique.fr - Linux centos linux 7.4.1708, Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz, Python 2.7.13
See https://gist.github.com/f20246a41a11f731d89d1be77bdc79b3 for a full test report.

@rdbisme
Copy link
Copy Markdown
Contributor Author

rdbisme commented Feb 26, 2018

@boegel Did not understand what's the problem with the automatic check...

boegel
boegel requested changes Feb 26, 2018
View reviewed changes
easybuild/easyconfigs/d/Doxygen/Doxygen-1.8.14-GCCcore-7.2.0.eb Outdated
Copy link
Copy Markdown
Member

@boegel boegel Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubendibattista You should include binutils 2.29 as a build dependency too when using GCCcore as toolchain (that's why the tests are failing).

@rdbisme rdbisme force-pushed the 20180223141731_new_pr_Doxygen1814 branch from 72cec47 to 4251569 Compare February 28, 2018 15:37
@rdbisme
Copy link
Copy Markdown
Contributor Author

rdbisme commented Mar 2, 2018

Should be ok now :)

@easybuilders easybuilders deleted a comment from boegelbot Mar 2, 2018
boegel
boegel requested changes Mar 2, 2018
View reviewed changes
easybuild/easyconfigs/d/Doxygen/Doxygen-1.8.14-GCCcore-7.2.0.eb Outdated
Copy link
Copy Markdown
Member

@boegel boegel Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubendibattista One of our most recent Doxygen easyconfigs also has pkg-config as build dep...

It's inconsistent with Doxygen 1.8.13, but can you check on this, and if pkg-config is indeed required include it here too?

Bonus point if you issue a separate PR to make pkg-config a build dep consistently in the Doxygen 1.8.13 easyconfigs... ;)

Copy link
Copy Markdown
Contributor Author

@rdbisme rdbisme Mar 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Doxygen manual, pkg-config is not listed in the requirements: https://www.stack.nl/~dimitri/doxygen/manual/install.html

Am I misreading something?

Copy link
Copy Markdown
Member

@boegel boegel Mar 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @JackPerdue can clarify, it seems like he added this (cfr. #4953).

I can't find a reference to the use pkg-config anywhere in the build log for Doxygen...

Copy link
Copy Markdown
Member

@boegel boegel Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and get this merged, and open a PR to remove the pkg-config build dep in the other Doxygen easyconfig, it's wrong imho...

@boegel boegel modified the milestones: 3.x, 3.6.0 Mar 2, 2018
@rdbisme rdbisme force-pushed the 20180223141731_new_pr_Doxygen1814 branch 2 times, most recently from 3cb6129 to cb9a0db Compare March 16, 2018 09:04
@rdbisme rdbisme force-pushed the 20180223141731_new_pr_Doxygen1814 branch from cb9a0db to eacc1bc Compare March 16, 2018 09:08
@rdbisme
Copy link
Copy Markdown
Contributor Author

rdbisme commented Mar 16, 2018

I rebased on upstream develop

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 16, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2573.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/74d77b5024b0d1a061dbb1fb3bbd9991 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 16, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2013.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/2531fe46e20c8d8b06198f35bd03ac17 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 16, 2018

Going in, thanks @rubendibattista!

@boegel boegel merged commit 8d9e3af into easybuilders:develop Mar 16, 2018
@rdbisme
Copy link
Copy Markdown
Contributor Author

rdbisme commented Mar 16, 2018

Thanks for the help and support.

@rdbisme rdbisme deleted the 20180223141731_new_pr_Doxygen1814 branch May 26, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rdbisme @boegel