Skip to content

{compiler}[intel/2017b] LLVM v5.0.0#5321

Merged
wpoely86 merged 4 commits intoeasybuilders:developfrom
boegel:20171109225441_new_pr_LLVM500
Nov 17, 2017
Merged

{compiler}[intel/2017b] LLVM v5.0.0#5321
wpoely86 merged 4 commits intoeasybuilders:developfrom
boegel:20171109225441_new_pr_LLVM500

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 9, 2017

(created using eb --new-pr)

@verdurin verdurin added this to the 3.5.0 milestone Nov 10, 2017
@verdurin verdurin closed this Nov 10, 2017
@verdurin verdurin reopened this Nov 10, 2017
@easybuilders easybuilders deleted a comment from boegelbot Nov 10, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 10, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2148.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/11712351e86f35954a803ac268daee4c for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 10, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2659.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/fd01abf32e54b22b0ff555e8742899c8 for a full test report.

@boegel boegel mentioned this pull request Nov 17, 2017
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 17, 2017

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in this PR)
node2077.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/4c98fe3cd9315ecbf84f6ac2c3092b40 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 17, 2017

Test report by @boegel
SUCCESS
Build succeeded for 25 out of 25 (7 easyconfigs in this PR)
node2702.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/c189d2e005aae4caae25ee486ea69ef8 for a full test report.

wpoely86
wpoely86 reviewed Nov 17, 2017
View reviewed changes
easybuild/easyconfigs/l/LLVM/LLVM-3.9.0-foss-2016b.eb
configopts = '-DBUILD_SHARED_LIBS=ON '
# required to install extra tools in bin/
configopts += '-DLLVM_INSTALL_UTILS=ON -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_ZLIB=ON '
configopts += "-DLLVM_INSTALL_UTILS=ON -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_ZLIB=ON -DLLVM_ENABLE_RTTI=1 "
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you change the quotes on this line, also do it on the others

Copy link
Copy Markdown
Member Author

@boegel boegel Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did where I could, but in some places there's a technical reason to use outer single quotes (which I prefer not to use when I can, for values that include spaces).

@wpoely86 wpoely86 merged commit 1682446 into easybuilders:develop Nov 17, 2017
@boegel boegel deleted the 20171109225441_new_pr_LLVM500 branch November 17, 2017 15:47
@boegel boegel mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @wpoely86 @verdurin