intltool 0.51.0 and patch to fix error in regular expression when using Perl 5.26.0#5287
intltool 0.51.0 and patch to fix error in regular expression when using Perl 5.26.0#5287reedts wants to merge 4 commits intoeasybuilders:developfrom
Conversation
|
Test report by @verdurin |
| @@ -0,0 +1,43 @@ | |||
| --- intltool-0.51.0.orig/intltool-update.in 2015-03-09 02:39:54.000000000 +0100 | |||
There was a problem hiding this comment.
@reedts Please include a description of why the patch is needed at the top of the patch. I know you've named it for compatibility, but a more specific description would be useful.
There was a problem hiding this comment.
Also: author or reference to upstream source of the patch.
We generally also include the software name/version in the filename.
If the Perl version is irrelevant (unclear to me), I'd avoid using 5.26.0 in the patch filename.
So, I'd suggest naming it intltool-0.51.0-fix-Perl-regex.patch...
There was a problem hiding this comment.
It seems to be needed for all versions of Perl since 5.23.0
I will update this next week.
| # https://bugs.launchpad.net/intltool/+bug/1696658 | ||
| # This patch ist from: | ||
| # https://github.com/Alexpux/MSYS2-packages/blob/master/intltool/perl-5.22-compatibility.patch | ||
| patches = ['intltool-perl-5.26.0-fix-regex.patch'] |
There was a problem hiding this comment.
@reedts Since the patch is in no way specific to Perl 5.26.0, I would avoid including a version number in the patch filename?
Do include the intltool version though, since the patch is specific to this version of intltool.
So, I'd suggest: intltool-%(version)s-Perl-fix-regex.patch.
There was a problem hiding this comment.
My bad. The problem seems to be specific to the combination of intltool-0.51.0 and Perl-5.26.0 but the patch file itself is not specific to this combination. I will fix that.
| # intltool bug with Perl 5.26 | ||
| # https://bugs.launchpad.net/intltool/+bug/1696658 | ||
| # This patch ist from: | ||
| # https://github.com/Alexpux/MSYS2-packages/blob/master/intltool/perl-5.22-compatibility.patch |
There was a problem hiding this comment.
no need to include these comments here, they're already in the patch file itself?
There was a problem hiding this comment.
Maybe just something like "fix regex error with perl 5.26.0" at this point, so one can understand instantly what the patch is for when reading the easyconfig?
There was a problem hiding this comment.
If people want to figure out what the patch does exactly, they can look into the patch file.
The patch filename could give a good first hint.
|
@boegel All right then, so we can close this? |
|
@reedts Yes. |
3 participants
depends on
#5288