Skip to content

{math}[GCCcore/6.4.0] METIS v5.1.0#4946

Merged
boegel merged 2 commits intoeasybuilders:developfrom
JackPerdue:20170723221948_new_pr_METIS510
Sep 8, 2017
Merged

{math}[GCCcore/6.4.0] METIS v5.1.0#4946
boegel merged 2 commits intoeasybuilders:developfrom
JackPerdue:20170723221948_new_pr_METIS510

Conversation

@JackPerdue
Copy link
Copy Markdown
Contributor

@JackPerdue JackPerdue commented Jul 24, 2017

(created using eb --new-pr)

@verdurin verdurin modified the milestone: 3.4.0 Jul 27, 2017
boegel
boegel requested changes Sep 6, 2017
View reviewed changes
easybuild/easyconfigs/m/METIS/METIS-5.1.0-GCCcore-6.4.0.eb Outdated
checksums = ['76faebe03f6c963127dbb73c13eab58c9a3faeae48779f049066a21c087c5db2']

# We use 32bit for indices and 64bit for content
patches = ['METIS-5.1.0-use-doubles.patch']
Copy link
Copy Markdown
Member

@boegel boegel Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackPerdue One tiny remark: please don't hardcode the version here, use the %(version)s template:

patches = ['METIS-%(version)s-use-doubles.patch']

@boegel boegel modified the milestones: 3.5.0, 3.4.0 Sep 6, 2017
@JackPerdue
Copy link
Copy Markdown
Contributor Author

JackPerdue commented Sep 8, 2017

I don't know why --update-pr pulled in CMake... its the same 3.9.1 as the one already in devel.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 8, 2017

@JackPerdue Probably because you combined --update-pr with --robot, which makes it pull in missing deps (that are not in your PR branch yet).

Nothing to worry about as long as there are no different to the CMake easyconfig.

It does confuse GitHub though, it shouldn't be showing the CMake in the diff, but we can check easily with current develop via eb --review-pr...

@boegel boegel mentioned this pull request Sep 8, 2017
Merged
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 8, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2402.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/673edd9bb8945d38819a75c635968cfc for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 8, 2017

Going in, thanks @JackPerdue!

@boegel boegel merged commit 78247d3 into easybuilders:develop Sep 8, 2017
@boegel boegel modified the milestones: 3.5.0, 3.4.0 Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JackPerdue @boegel @verdurin