Skip to content

{lang}[GCCcore/6.4.0] Python v2.7.13#4914

Closed
JackPerdue wants to merge 4 commits intoeasybuilders:developfrom
JackPerdue:20170719190546_new_pr_Python2713
Closed

{lang}[GCCcore/6.4.0] Python v2.7.13#4914
JackPerdue wants to merge 4 commits intoeasybuilders:developfrom
JackPerdue:20170719190546_new_pr_Python2713

Conversation

@JackPerdue
Copy link
Copy Markdown
Contributor

@JackPerdue JackPerdue commented Jul 20, 2017

(created using eb --new-pr)
depends on PR #4913

@JackPerdue JackPerdue mentioned this pull request Jul 20, 2017
Merged
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 20, 2017

Travis test report: 8/8 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/255477644

Only showing partial log for 1st failed test suite run 5443.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/255477645

...
FAIL: Test for parsing of easyconfig Python-2.7.13-GCCcore-6.4.0-bare.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 1, in innertest
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 342, in template_easyconfig_test
    self.assertEqual(orig_val, dumped_val)
AssertionError: "\n    sed -e 's:Modules/python.o \\\\:-Wl,-rpath=/dummy/installdir/lib Modules/python.o \\\\:' -i.eb Makefile\n" != "\n    sed -e 's:Modules/python.o \\:-Wl,-rpath=/dummy/installdir/lib Modules/python.o \\:' -i.eb Makefile\n"

======================================================================
FAIL: Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/styletests.py", line 61, in test_style_conformance
    self.assertEqual(result, 0, "Found code style errors (and/or warnings): %s" % result)
AssertionError: Found code style errors (and/or warnings): 2

----------------------------------------------------------------------
Ran 7366 tests in 136.941s

FAILED (failures=2)
ERROR: Not all tests were successful.

(bleep, bloop, I'm just a bot, please talk to my owner @boegel if you notice you me acting stupid)

This was referenced Jul 20, 2017
Merged
Merged
verdurin
verdurin requested changes Jul 20, 2017
View reviewed changes
easybuild/easyconfigs/p/Python/Python-2.7.13-GCCcore-6.4.0-bare.eb Outdated
# We hide this by default since users should not use it in production,
# high-performance Python should be delivered at compiler level with
# a default extension set
#hidden = True
Copy link
Copy Markdown
Member

@verdurin verdurin Jul 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the style errors reported by Travis:

/home/travis/build/easybuilders/easybuild-easyconfigs/easybuild/easyconfigs/p/Python/Python-2.7.13-GCCcore-6.4.0-bare.eb:42:1: E265 block comment should start with '# '

easybuild/easyconfigs/s/SQLite/SQLite-3.19.3-GCCcore-6.4.0.eb Outdated
# eg. http://www.sqlite.org/2017/sqlite-autoconf-3190300.tar.gz
source_urls = ['http://www.sqlite.org/2017/']
version_str = '%%(version_major)s%s00' % ''.join('%02d' %
int(x) for x in version.split('.')[1:])
Copy link
Copy Markdown
Member

@verdurin verdurin Jul 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another style error:

/home/travis/build/easybuilders/easybuild-easyconfigs/easybuild/easyconfigs/s/SQLite/SQLite-3.19.3-GCCcore-6.4.0.eb:28:15: E128 continuation line under-indented for visual indent

Copy link
Copy Markdown
Member

@verdurin verdurin Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackPerdue please remove this file, now that I've merged the separate SQLite PR

@verdurin verdurin added this to the 3.4.0 milestone Jul 20, 2017
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jul 20, 2017

@JackPerdue - also, why the duplication of SQLite and Tcl?

@JackPerdue
Copy link
Copy Markdown
Contributor Author

JackPerdue commented Jul 20, 2017

@verdurin "also, why the duplication of SQLite and Tcl?" @boegel mentioned on slack that if I have a new PR that depends on stuff from PRs already submitted but not merged yet to just include the (duplicates) and cite the original PR

@JackPerdue JackPerdue mentioned this pull request Jul 20, 2017
Closed
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 20, 2017

Travis test report: 8/8 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/255849054

Only showing partial log for 1st failed test suite run 5463.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/255849055

...
FAIL: Test for parsing of easyconfig Python-2.7.13-GCCcore-6.4.0-bare.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 1, in innertest
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 342, in template_easyconfig_test
    self.assertEqual(orig_val, dumped_val)
AssertionError: "\n    sed -e 's:Modules/python.o \\\\:-Wl,-rpath=/dummy/installdir/lib Modules/python.o \\\\:' -i.eb Makefile\n" != "\n    sed -e 's:Modules/python.o \\:-Wl,-rpath=/dummy/installdir/lib Modules/python.o \\:' -i.eb Makefile\n"

======================================================================
FAIL: Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/styletests.py", line 61, in test_style_conformance
    self.assertEqual(result, 0, "Found code style errors (and/or warnings): %s" % result)
AssertionError: Found code style errors (and/or warnings): 1

----------------------------------------------------------------------
Ran 7367 tests in 134.415s

FAILED (failures=2)
ERROR: Not all tests were successful.

(bleep, bloop, I'm just a bot, please talk to my owner @boegel if you notice you me acting stupid)

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 21, 2017

Travis test report: 8/8 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/256214373

Only showing partial log for 1st failed test suite run 5482.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/256214374

...
FAIL: Test for parsing of easyconfig Python-2.7.13-GCCcore-6.4.0-bare.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 1, in innertest
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 342, in template_easyconfig_test
    self.assertEqual(orig_val, dumped_val)
AssertionError: "\n    sed -e 's:Modules/python.o \\\\:-Wl,-rpath=/dummy/installdir/lib Modules/python.o \\\\:' -i.eb Makefile\n" != "\n    sed -e 's:Modules/python.o \\:-Wl,-rpath=/dummy/installdir/lib Modules/python.o \\:' -i.eb Makefile\n"

----------------------------------------------------------------------
Ran 7367 tests in 145.431s

FAILED (failures=1)
ERROR: Not all tests were successful.

(bleep, bloop, I'm just a bot, please talk to my owner @boegel if you notice you me acting stupid)

@JackPerdue
Copy link
Copy Markdown
Contributor Author

JackPerdue commented Jul 21, 2017

[j-perdue@terra2 2017b]$ eb --check-style Python-2.7.13-GCCcore-6.4.0-bare.eb.terra
== temporary log file in case of crash /tmp/j-perdue/tmp/eb-CRRlD1/easybuild-lZiD7s.log
Running style check on 1 easyconfig(s)...
[PASS] /general/sw/eb/hprc/ec-dev/2017b/Python-2.7.13-GCCcore-6.4.0-bare.eb.terra
All style checks passed!
== Temporary log file(s) /tmp/j-perdue/tmp/eb-CRRlD1/easybuild-lZiD7s.log* have been removed.
== Temporary directory /tmp/j-perdue/tmp/eb-CRRlD1 has been removed.
[j-perdue@terra2 2017b]$

Works here.

Not sure what Travis's problem is.

@verdurin verdurin closed this Jul 21, 2017
@verdurin verdurin reopened this Jul 21, 2017
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 21, 2017

Travis test report: 8/8 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/256227610

Only showing partial log for 1st failed test suite run 5483.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/256227611

...
FAIL: Test for parsing of easyconfig Python-2.7.13-GCCcore-6.4.0-bare.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 1, in innertest
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 342, in template_easyconfig_test
    self.assertEqual(orig_val, dumped_val)
AssertionError: "\n    sed -e 's:Modules/python.o \\\\:-Wl,-rpath=/dummy/installdir/lib Modules/python.o \\\\:' -i.eb Makefile\n" != "\n    sed -e 's:Modules/python.o \\:-Wl,-rpath=/dummy/installdir/lib Modules/python.o \\:' -i.eb Makefile\n"

----------------------------------------------------------------------
Ran 7367 tests in 144.418s

FAILED (failures=1)
ERROR: Not all tests were successful.

(bleep, bloop, I'm just a bot, please talk to my owner @boegel if you notice you me acting stupid)

@verdurin verdurin closed this Jul 26, 2017
@verdurin verdurin reopened this Jul 26, 2017
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 26, 2017

Travis test report: 8/8 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/257666854

Only showing partial log for 1st failed test suite run 5504.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/257666855

...
FAIL: Test for parsing of easyconfig Python-2.7.13-GCCcore-6.4.0-bare.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 1, in innertest
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 342, in template_easyconfig_test
    self.assertEqual(orig_val, dumped_val)
AssertionError: "\n    sed -e 's:Modules/python.o \\\\:-Wl,-rpath=/dummy/installdir/lib Modules/python.o \\\\:' -i.eb Makefile\n" != "\n    sed -e 's:Modules/python.o \\:-Wl,-rpath=/dummy/installdir/lib Modules/python.o \\:' -i.eb Makefile\n"

----------------------------------------------------------------------
Ran 7367 tests in 142.867s

FAILED (failures=1)
ERROR: Not all tests were successful.

(bleep, bloop, I'm just a bot, please talk to my owner @boegel if you notice you me acting stupid)

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jul 27, 2017

@JackPerdue I don't know why Travis is complaining either.

Might have to wait until @boegel returns, or we can find someone with superior Travis knowledge.

@JackPerdue JackPerdue mentioned this pull request Jul 30, 2017
Merged
@JackPerdue
Copy link
Copy Markdown
Contributor Author

JackPerdue commented Jul 30, 2017

New version submitted as PR #4962

I can't seem to use --update-pr without it wanting to drag in SQLite and TCL again... perhaps due to the way I removed them from this PR (deleting from branch in GitHub web thingie). In any case, see the new one (tried to remove all the backslashes to make Travis happy).

@JackPerdue
Copy link
Copy Markdown
Contributor Author

JackPerdue commented Jul 30, 2017

Travis seems much happier with #4962... closing this one.

@JackPerdue JackPerdue closed this Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JackPerdue @boegelbot @verdurin