Skip to content

Fix ubsan error blocking build of GCCcore 6.1.0, 6.2.0, 6.3.0 with system GCC 7.1#4813

Merged
boegel merged 3 commits intoeasybuilders:developfrom
zao:20170705095440_new_pr_GCCcore630
Jul 6, 2017
Merged

Fix ubsan error blocking build of GCCcore 6.1.0, 6.2.0, 6.3.0 with system GCC 7.1#4813
boegel merged 3 commits intoeasybuilders:developfrom
zao:20170705095440_new_pr_GCCcore630

Conversation

@zao
Copy link
Copy Markdown
Contributor

@zao zao commented Jul 5, 2017

(created using eb --new-pr)

boegel
boegel requested changes Jul 5, 2017
View reviewed changes
easybuild/easyconfigs/g/GCCcore/GCCcore-6.3.0-fix-ubsan.patch
@@ -0,0 +1,12 @@
diff -ru gcc-6.3.0-orig/gcc/ubsan.c gcc-6.3.0/gcc/ubsan.c
Copy link
Copy Markdown
Member

@boegel boegel Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zao Please mention source/author for this patch above this line, and maybe also a short description of the problem it fixes (& how)

easybuild/easyconfigs/g/GCCcore/GCCcore-6.3.0.eb Outdated
patches = [
('mpfr-%s-allpatches-20161215.patch' % mpfr_version, '../mpfr-%s' % mpfr_version),
'GCCcore-6.2.0-fix-find-isl.patch',
'GCCcore-6.3.0-fix-ubsan.patch',
Copy link
Copy Markdown
Member

@boegel boegel Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zao Please use %(version)s when the version in the patch name matches the version, rather than hardcoding it.

I assume this patch is irrelevant for GCC 6.4.0 (#4794)?

@boegel boegel added this to the 3.3.1 milestone Jul 5, 2017
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 5, 2017

@zao Please edit the PR title, since you're patching an existing easyconfig file.

I need to change --new-pr to enforce that when it notices you're patching an existing file...

@zao zao changed the title {compiler}[dummy/] GCCcore v6.3.0 Fix error blocking build of GCCcore v6.3.0 with system GCC 7.1 Jul 5, 2017
@zao
Copy link
Copy Markdown
Contributor Author

zao commented Jul 5, 2017

The bug seems to be introduced upstream in the 6 series, 5.4.0 is unaffected.
The bug is present in 6.1.0 and 6.2.0 releases, 6.4.0 is fixed by upstream.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 5, 2017

@zao In that case, please also include the patch in GCCcore-6.1.0.eb and GCCcore-6.2.0.eb, and maybe change the patch filename to use 6.x rather than 6.3.0?

@zao zao changed the title Fix error blocking build of GCCcore v6.3.0 with system GCC 7.1 Fix ubsan error blocking build of GCCcore 6.1.0, 6.2.0, 6.3.0 with system GCC 7.1 Jul 5, 2017
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 5, 2017

lgtm, test reports coming in

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 6, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2402.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/8a2d49cf4778358aa2d9ee36a5492994 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 6, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2104.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/2220065138a52346aa73846330073b04 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 6, 2017

Going in, thanks @zao!

@boegel boegel merged commit 4925a4c into easybuilders:develop Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3.1

Development

Successfully merging this pull request may close these issues.

2 participants

@zao @boegel