Skip to content

Added Clang-3.3#424

Merged
boegel merged 9 commits intoeasybuilders:developfrom
wpoely86:clang33
Sep 18, 2013
Merged

Added Clang-3.3#424
boegel merged 9 commits intoeasybuilders:developfrom
wpoely86:clang33

Conversation

@wpoely86
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 commented Sep 6, 2013

Clang 3.3 needs at least cmake 2.8.8 so I updated the necessary easyconfigs.

Depends on easybuilders/easybuild-easyblocks#248

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have no objections with the licensing scheme, I'd say add yourself in the list of authors;
having a couple of authors per (complex) easyconfig is good for "parenting" them...

Otherwise, nice work! that will also help #350 now...

@wpoely86
Copy link
Copy Markdown
Member Author

wpoely86 commented Sep 9, 2013

OK, I've made the requested changes. I've a look at #350 when I can.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use %(version)s (same below)

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 18, 2013

@wpoely: Do you have a reference you can mention for the patch files, e.g. a bug ticket in the Clang bug tracker that confirms the issue (and maybe mentions how to dance around it)?

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 18, 2013

Hmm, building ncurses-5.9 with GCC-4.8.1 failed on my end (see below). Did it work for you? If so, which OS?

gcc -I. -I. -I../test -DHAVE_CONFIG_H  -D_GNU_SOURCE -DNDEBUG -I. -I../include -I/user/scratch/gent/vsc400/vsc40023/easybuild_REGTEST/SL6/sandybridge/software/ncurses/5.9-GCC-4.8.1/include -fPIC -O2 -march=native  --param max-inline-insns-single=1200  -fPIC -c ../test/tclock.c -o ../obj_s/tclock.o
../test/tclock.c: In function 'main':
../test/tclock.c:190:4: warning: assignment makes pointer from integer without a cast [enabled by default]
  t = localtime(&tim);
    ^
../test/tclock.c:192:12: error: dereferencing pointer to incomplete type
  hours = (t->tm_hour + (t->tm_min / 60.0));
            ^
../test/tclock.c:192:26: error: dereferencing pointer to incomplete type
  hours = (t->tm_hour + (t->tm_min / 60.0));
                          ^
../test/tclock.c:196:14: error: dereferencing pointer to incomplete type
  mangle = ((t->tm_min + (t->tm_sec / 60.0)) * (2 * PI) / 60.0);
              ^
../test/tclock.c:196:27: error: dereferencing pointer to incomplete type
  mangle = ((t->tm_min + (t->tm_sec / 60.0)) * (2 * PI) / 60.0);
                           ^
../test/tclock.c:208:14: error: dereferencing pointer to incomplete type
  sangle = ((t->tm_sec + fraction) * (2.0 * PI) / 60.0);
              ^
../test/tclock.c:226:7: warning: assignment makes pointer from integer without a cast [enabled by default]
  text = ctime(&tim);
       ^
../test/tclock.c:229:8: error: dereferencing pointer to incomplete type
  if ((t->tm_sec % 5) == 0
        ^
../test/tclock.c:230:10: error: dereferencing pointer to incomplete type
      && t->tm_sec != lastbeep) {
          ^
../test/tclock.c:231:18: error: dereferencing pointer to incomplete type
      lastbeep = t->tm_sec;
                  ^
make[1]: *** [../obj_s/tclock.o] Error 1

@wpoely86
Copy link
Copy Markdown
Member Author

@boegel I don't have one. It's something strange in the build/test suite of clang. It tries to use a 32 bit version of the asan lib which isn't there. asan itself seems to work fine. If I find the time, I will take a closer look but for now, I've just disabled the tests. This should not affect Clang itself as you have to explicit compile with a flag to enable asan or tsan.

@wpoely86
Copy link
Copy Markdown
Member Author

I've build this branch on my Fedora 19 system without issue.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 18, 2013

Hmm, http://www.unix.com/programming/121283-c-compilation-problem.html suggests it's just a matter of a faulty include... Will test on my end.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 18, 2013

Nevermind, I was accidentally using a SL5 GCC build on SL6, which is asking for trouble.
Testing the Clang build now...

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 18, 2013

OK, Clang build did work on my end after all, so good to merge in!

Thanks @wpoely86!

boegel added a commit that referenced this pull request Sep 18, 2013
@boegel boegel merged commit 3c75993 into easybuilders:develop Sep 18, 2013
@wpoely86 wpoely86 deleted the clang33 branch September 18, 2013 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants