Skip to content

{ai}[foss/2024a] Orange3 v3.40.0#25436

Open
sassy-crick wants to merge 9 commits intoeasybuilders:developfrom
sassy-crick:20260226004107_new_pr_Orange33400
Open

{ai}[foss/2024a] Orange3 v3.40.0#25436
sassy-crick wants to merge 9 commits intoeasybuilders:developfrom
sassy-crick:20260226004107_new_pr_Orange33400

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Feb 26, 2026

@github-actions github-actions bot added the 2024a issues & PRs related to 2024a common toolchains label Feb 26, 2026
@sassy-crick
Copy link
Copy Markdown
Collaborator Author

Test report by @sassy-crick
SUCCESS
Build succeeded for 1 out of 1 (total: 7 mins 31 secs) (1 easyconfigs in total)
hp - Linux Debian GNU/Linux 12, x86_64, 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz, Python 3.11.2
See https://gist.github.com/sassy-crick/cd18a1bba8c5d83856c7003f605bb3cb for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor

I just tried to build this: The libcst extension requires Rust. So this needs to be a CargoPythonBundle with crates or that extension pulled out to a separate easyconfig.

  copying libcst/_parser/conversions/README.md -> build/lib.linux-x86_64-cpython-312/libcst/_parser/conversions
  running build_ext
  running build_rust

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

I just tried to build this: The libcst extension requires Rust. So this needs to be a CargoPythonBundle with crates or that extension pulled out to a separate easyconfig.

  copying libcst/_parser/conversions/README.md -> build/lib.linux-x86_64-cpython-312/libcst/_parser/conversions
  running build_ext
  running build_rust

I noticed that as well, however, switching to RustPythonBundlegave me other issues; and I was not sure if pulling this package out might be a right way forward.
However, I think this is actually the better way of doing it, so let me pull that out and update the PR accordingly.

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

I pulled out libcst from the Orange3 as a separate EasyConfig file. What foxed me was: there was no Cargo.toml file in the source code. Turns out they somehow download it, so I got the cargo-list that way. Please let me know if I forgot a crate for libcst.

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

Test report by @sassy-crick
SUCCESS
Build succeeded for 2 out of 2 (total: 5 mins 35 secs) (2 easyconfigs in total)
hp - Linux Debian GNU/Linux 12, x86_64, 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz, Python 3.11.2
See https://gist.github.com/sassy-crick/491fbdae76dbe7b02e7a46500858a39d for a full test report.

@@ -0,0 +1,274 @@
# Author: J. Saßmannshausen (Imperial College London/UK)

easyblock = 'CargoPythonBundle'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has only a single Python package, so better use

Suggested change
easyblock = 'CargoPythonBundle'
easyblock = 'CargoPythonPackage'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I have done the requested changes, here and below.
I had the impression that Bundle is a bit more the preferred way but I could be wrong.

Comment on lines +268 to +272
exts_list = [
(name, version, {
'checksums': ['8478abf21ae3861a073e898d80b822bd56e578886331b33129ba77fec05b8c24'],
}),
]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exts_list = [
(name, version, {
'checksums': ['8478abf21ae3861a073e898d80b822bd56e578886331b33129ba77fec05b8c24'],
}),
]
sources = [SOURCE_TAR_GZ]

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

('winnow', '0.6.18'),
]
checksums = [
{'aho-corasick-1.0.4.tar.gz': '6748e8def348ed4d14996fa801f4122cd763fff530258cdc03f64b25f89d3a5a'},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{'aho-corasick-1.0.4.tar.gz': '6748e8def348ed4d14996fa801f4122cd763fff530258cdc03f64b25f89d3a5a'},
{'libcst-1.5.0.tar.gz': '8478abf21ae3861a073e898d80b822bd56e578886331b33129ba77fec05b8c24'},
{'aho-corasick-1.0.4.tar.gz': '6748e8def348ed4d14996fa801f4122cd763fff530258cdc03f64b25f89d3a5a'},

At least I hope I typed that correctly

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

@Flamefire
Copy link
Copy Markdown
Contributor

Test report by @Flamefire
SUCCESS
Build succeeded for 13 out of 13 (total: 1 hour 36 mins 3 secs) (13 easyconfigs in total)
i7064 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.9.21
See https://gist.github.com/Flamefire/b8ba82ae37824d32f84198b3c69d2576 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor

Flamefire commented Mar 4, 2026

Test report by @Flamefire
FAILED
Build succeeded for 37 out of 38 (total: 3 hours 23 mins 3 secs) (13 easyconfigs in total)
c128 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 9334 32-Core Processor (zen4), 4 x NVIDIA NVIDIA H100, 580.65.06, Python 3.9.21
See https://gist.github.com/Flamefire/c57c8241c823419f6082d8b958c63bee for a full test report.

Failed only for #25470, SUCCESS here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2024a issues & PRs related to 2024a common toolchains new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants