Skip to content

[BUGFIX:GROMACS] Build with gmxapi distributed with the GROMACS source code#25188

Open
gkaf89 wants to merge 3 commits intoeasybuilders:developfrom
gkaf89:gromax-gmxapi
Open

[BUGFIX:GROMACS] Build with gmxapi distributed with the GROMACS source code#25188
gkaf89 wants to merge 3 commits intoeasybuilders:developfrom
gkaf89:gromax-gmxapi

Conversation

@gkaf89
Copy link
Copy Markdown
Collaborator

@gkaf89 gkaf89 commented Jan 30, 2026

The gmxapi from PyPI is replaced with the version distributed with GROMACS. The version in GROMACS source code is slightly newer.

The version number mentioned in the TOML file is out of date. The correct number is located in

python_packaging/gmxapi/src/gmxapi/version.py

and agrees with the documentation. This commit also patches the TOML file to ensure that the package number in the Python environment is the same as the package number in version.py.

Related pull requests

Related issues

Issue reported upstream: https://gitlab.com/gromacs/gromacs/-/issues/5554

@github-actions github-actions bot added 2023b 2025a issues & PRs related to 2025a common toolchains 2025b issues & PRs related to 2025b common toolchains change labels Jan 30, 2026
@gkaf89 gkaf89 marked this pull request as draft January 30, 2026 09:21
@gkaf89
Copy link
Copy Markdown
Collaborator Author

gkaf89 commented Jan 30, 2026

Waiting for a response in the upstream issue to set to ready.

@gkaf89 gkaf89 marked this pull request as ready for review February 4, 2026 16:21
@gkaf89
Copy link
Copy Markdown
Collaborator Author

gkaf89 commented Feb 4, 2026

There was no reply in the issue in GROMACS, so I am marking as ready.

FelixBangerter pushed a commit to FelixBangerter/easybuild-easyconfigs that referenced this pull request Feb 8, 2026
@gkaf89 gkaf89 marked this pull request as draft February 18, 2026 11:15
@gkaf89 gkaf89 marked this pull request as ready for review February 18, 2026 11:29
@gkaf89 gkaf89 marked this pull request as draft February 18, 2026 15:17
…rce code

The gmxapi from PyPI is replaced with the version distributed with GROMACS. The
version in GROMACS source code is slightly newer.

The version number mentioned in the TOML file is out of date. The correct
number is located in:

python_packaging/gmxapi/src/gmxapi/version.py

This commit also patches the TOML file to ensure that the package number in the
Python environment is the same as the package number in `version.py`.
@boegel boegel added this to the release after 5.2.1 milestone Feb 18, 2026
@boegel boegel added bug fix and removed change labels Feb 18, 2026
@gkaf89 gkaf89 marked this pull request as ready for review February 19, 2026 09:46
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 8, 2026

@boegelbot please test @ jsc-zen3-a100
CORE_CNT=16
EB_ARGS="--installpath /tmp/$USER/pr25188"

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25188 EB_ARGS="--installpath /tmp/$USER/pr25188" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25188 --ntasks="16" --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10185

Test results coming soon (I hope)...

Details

- notification for comment with ID 4208835468 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2023b 2025a issues & PRs related to 2025a common toolchains 2025b issues & PRs related to 2025b common toolchains bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants