Switch to setuptools and find_packages#24747
Open
Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Open
Switch to setuptools and find_packages#24747Flamefire wants to merge 2 commits intoeasybuilders:developfrom
find_packages#24747Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Conversation
This was referenced Dec 4, 2025
Any reasonably modern Python distribution includes setuptools. So the workaround, that was useful for Python 2.x, is no longer necessary and can be removed. This allows using `find_packages` instead of maintaining an explicit list of packages which is error-prone.
Requires installing setuptools explicitely
Member
|
I'm not keen on this, see discussion in easybuilders/easybuild-framework#5065 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any reasonably modern Python distribution includes setuptools.
it was useful for Python 2.x, is no longer necessary and can be removed making it consistent for all 3 EB packages:
easybuilders/easybuild-easyblocks#4006
easybuilders/easybuild-framework#5065
Also add a test with Python 3.12 which was missing for this test suite but present in the others