Skip to content

enable running of tests for spdlog 1.15.3 #24391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crivella merged 4 commits into from
Oct 29, 2025
Merged

enable running of tests for spdlog 1.15.3 #24391

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d567ae
Dynamic library build and test job added
Oct 29, 2025
efaa579
PIC support added
Oct 29, 2025
4a9d515
check for shared/static libs added, missing configopts added
Oct 29, 2025
cdcaaec
configopts corrected
Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-14.3.0.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ version = '1.15.3'

homepage = 'https://github.com/gabime/spdlog'
description = "Very fast, header-only/compiled, C++ logging library."

toolchain = {'name': 'GCCcore', 'version': '14.3.0'}
toolchainopts = {'pic': True}

Expand All @@ -17,15 +18,14 @@ builddependencies = [
('CMake', '4.0.3'),
]

_shared_configopts = " ".join([
"-DSPDLOG_BUILD_SHARED=ON",
"-DSPDLOG_BUILD_PIC=ON",
])
_base_configopts = ' -DSPDLOG_BUILD_TESTS=ON -DSPDLOG_BUILD_PIC=ON '

configopts = [f'{_base_configopts} -DSPDLOG_BUILD_SHARED={x}' for x in ('OFF', 'ON')]

configopts = ["", _shared_configopts]
runtest = 'test'

sanity_check_paths = {
'files': ['include/%(name)s/%(name)s.h', 'lib/lib%(name)s.a', f'lib/lib%(name)s.{SHLIB_EXT}'],
'files': [f'include/{name}/{name}.h', 'lib/libspdlog.a', f'lib/libspdlog.{SHLIB_EXT}'],
'dirs': ['lib64/cmake', 'lib64/pkgconfig'],
Comment on lines 27 to 29
Copy link
Copy Markdown
Contributor

@Crivella Crivella Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would keep consistent usage of f-strings without re-introducing old % formatting.

Copy link
Copy Markdown
Collaborator Author

@sassy-crick sassy-crick Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I done my PR without being aware of what you already done @Crivella . So that is why I had already the f-string for the bit I knew how to do it, but I was not sure how to do it for the SHLIB_EXT bit. So now that is consistent, thanks fo your help.

}

Expand Down