Skip to content

add patch for EasyBuild v5.1.2 to fix long-lived bug with toolchain prepare when not using $CPATH#24376

Merged
bedroge merged 3 commits intoeasybuilders:developfrom
ocaisa:20251027093648_new_pr_EasyBuild512
Oct 28, 2025
Merged

add patch for EasyBuild v5.1.2 to fix long-lived bug with toolchain prepare when not using $CPATH#24376
bedroge merged 3 commits intoeasybuilders:developfrom
ocaisa:20251027093648_new_pr_EasyBuild512

Conversation

@ocaisa
Copy link
Member

@ocaisa ocaisa commented Oct 27, 2025

The bug has been exposed when using the new options EASYBUILD_MODULE_SEARCH_PATH_HEADERS=include_paths and EASYBUILD_SEARCH_PATH_CPP_HEADERS=include_paths so that CPATH is no longer set with EESSI/2025.06

@ocaisa
Copy link
Member Author

ocaisa commented Oct 27, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24376 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24376 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8558

Test results coming soon (I hope)...

Details

- notification for comment with ID 3450348295 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/9e28ad4799ba7cbe7a2e51f50c0d879f for a full test report.

@bedroge bedroge added this to the next release (5.2.0?) milestone Oct 28, 2025
Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. This fixes a serious bug affecting anyone using a non-default search path configuration, so patching the EasyBuild easyconfig makes sense to me.

@bedroge
Copy link
Contributor

bedroge commented Oct 28, 2025

Going in, thanks @ocaisa!

@bedroge bedroge merged commit 693cd33 into easybuilders:develop Oct 28, 2025
8 checks passed
@boegel boegel changed the title Fix long-lived EasyBuild bug with toolchain prepare when not using CPATH add patch for EasyBuild v5.1.2 to fix long-lived bug with toolchain prepare when not using $CPATH Dec 19, 2025
@boegel boegel removed the change label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants