Fix failing test_pr_python_packages when extensions have templates#24260
Merged
Micket merged 1 commit intoeasybuilders:developfrom Oct 15, 2025
Merged
Conversation
We don't need to resolve templates for this test so don't try. This fails if e.g. `%(start_dir)s` is used. Similar for `test_pr_R_packages`
Micket
approved these changes
Oct 15, 2025
Contributor
Micket
left a comment
Micket
left a comment
There was a problem hiding this comment.
lgtm
Not super sure about the code here, but I do trust you have thought it through
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to resolve templates for this test so don't try. This fails if e.g.
%(start_dir)sis used.Similar for
test_pr_R_packages