Skip to content

Avoid test failures due to concurrency issue in modkit#24234

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20251014124851_new_pr_modkit033
Oct 15, 2025
Merged

Avoid test failures due to concurrency issue in modkit#24234
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20251014124851_new_pr_modkit033

Conversation

@Flamefire
Copy link
Contributor

(created using eb --new-pr)

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the next release (5.2.0?) milestone Oct 14, 2025
@Micket Micket added bug fix and removed change labels Oct 14, 2025
@Micket
Copy link
Contributor

Micket commented Oct 14, 2025

@boegelbot please test @ jsc-zen3

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3665
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
c144 - Linux AlmaLinux 9.4, x86_64, AMD EPYC 9334 32-Core Processor (zen4), 4 x NVIDIA NVIDIA H100, 560.35.03, Python 3.9.18
See https://gist.github.com/Flamefire/48d838518e85f0ef4532c58952a5f267 for a full test report.

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24234 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24234 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8360

Test results coming soon (I hope)...

Details

- notification for comment with ID 3401418067 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/dd829e8f6482a125c3be9af49818557c for a full test report.

@Flamefire
Copy link
Contributor Author

assertion left == right failed: record 10fc76b1-f06f-42f5-9275-09cd438c1db5 not the same
left: Record(tid: 3, pos: 57)
right: Record(tid: 0, pos: 20)

I've seen that too but it went away on second run or manual execution. Not sure what to do about this

@boegel
Copy link
Member

boegel commented Oct 14, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24234 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24234 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8371

Test results coming soon (I hope)...

Details

- notification for comment with ID 3403233949 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/055f649f123452343157cb47bbe80f6e for a full test report.

@Micket
Copy link
Contributor

Micket commented Oct 14, 2025

it is an old version, I'd say lets not get to hung up on it

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Oct 15, 2025

Going in, thanks @Flamefire!

@boegel boegel merged commit fc5e960 into easybuilders:develop Oct 15, 2025
8 checks passed
@Flamefire Flamefire deleted the 20251014124851_new_pr_modkit033 branch October 15, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2023a 2024a issues & PRs related to 2024a common toolchains bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants