Skip to content

add patch for GCCcore 10.3-13.2 to fix AVX-512 vectorizer bug (upstream PR 114566)#24073

Merged
Micket merged 1 commit intoeasybuilders:developfrom
ComputeCanada:gcc-fix-avx512-crash
Oct 3, 2025
Merged

add patch for GCCcore 10.3-13.2 to fix AVX-512 vectorizer bug (upstream PR 114566)#24073
Micket merged 1 commit intoeasybuilders:developfrom
ComputeCanada:gcc-fix-avx512-crash

Conversation

@bartoldeman
Copy link
Contributor

@bartoldeman bartoldeman commented Oct 1, 2025

This fixes a segmentation fault in FlexiBLAS LAPACK tests when
compiling for Zen4/Zen5

See also:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114566 and easybuilders#23974
@bartoldeman bartoldeman changed the title {compiler}[system/system] Add upstream PR 114566 fix to 10.3-13.2 {compiler}[system/system] GCCcore: Add upstream PR 114566 fix to 10.3-13.2 Oct 1, 2025
@github-actions github-actions bot added the change label Oct 1, 2025
@bartoldeman
Copy link
Contributor Author

still need to double check with 13.2 (I know the patch applies but haven't confirmed flexiblas)

@bartoldeman bartoldeman added this to the next release (5.2.0?) milestone Oct 1, 2025
@bartoldeman
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@bartoldeman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24073 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24073 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8109

Test results coming soon (I hope)...

Details

- notification for comment with ID 3356597426 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bartoldeman
Copy link
Contributor Author

Confirmed that this works with unpatched FlexiBLAS-3.3.1-GCC-12.3.0.eb and FlexiBLAS-3.3.1-GCC-13.2.0.eb with -march=znver4

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/269d4a127475e373ebdc964250da7f12 for a full test report.

@arielzn
Copy link
Contributor

arielzn commented Oct 3, 2025

I tested to rebuild GCCcore from here for 13.2.0, 12.3.0 and 12.2.0

they all worked to build the current unpatched FlexiBLAS easyconfigs, so I guess we can close #23974 and #23994

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 7201cf2 into easybuilders:develop Oct 3, 2025
8 checks passed
@boegel boegel changed the title {compiler}[system/system] GCCcore: Add upstream PR 114566 fix to 10.3-13.2 add patch for GCCcore 10.3-13.2 to fix AVX-512 vectorizer bug (upstream PR 114566) Oct 8, 2025
@boegel boegel added bug fix and removed change labels Oct 8, 2025
@@ -0,0 +1,120 @@
From 327533790760809abd2549e613a676dde5f8cd93 Mon Sep 17 00:00:00 2001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened a follow-up PR to add a reference to the GCC bug in these patch files:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants