Skip to content

improve reported errors in easyconfigs test suite#23969

Merged
boegel merged 6 commits intoeasybuilders:developfrom
Flamefire:test-conflict-enhancement
Apr 7, 2026
Merged

improve reported errors in easyconfigs test suite#23969
boegel merged 6 commits intoeasybuilders:developfrom
Flamefire:test-conflict-enhancement

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Sep 23, 2025

@Thyre Thyre added the tests label Sep 23, 2025
Use the new `return_conflicts` parameter to show the conflicts in the
error message instead of printing it to stderr during the status output
when the test is run.
Especially "binutils or GCC is a build dep: " is a misleading message
when the test fails because it is not.
@Flamefire
Copy link
Copy Markdown
Contributor Author

@boegel Can we get this in please? Found another instance where this would have helped: https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/21939459431/job/63361191232?pr=25045

@boegel boegel added this to the release after 5.2.1 milestone Feb 12, 2026
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 7, 2026

@Flamefire This needs another extra tiny change because of change in return value?

FAIL: test_conflicts (test.easyconfigs.easyconfigs.EasyConfigTest.test_conflicts)
Check whether any conflicts occur in software dependency graphs.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 331, in test_conflicts
    self.assertEqual(check_conflicts(self.ordered_specs, modules_tool(), check_inter_ec_conflicts=False,
AssertionError: [] != ''

Or maybe just assertFalse ?

Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
@Flamefire
Copy link
Copy Markdown
Contributor Author

Yes, should be an empty list

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 2bbd5a1 into easybuilders:develop Apr 7, 2026
6 checks passed
@Flamefire Flamefire deleted the test-conflict-enhancement branch April 8, 2026 06:41
@boegel boegel changed the title Enhance reported error in tests improve reported errors in easyconfigs test suite Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants