{lib}[GCC/14.2.0] pocl v7.0#23615
Conversation
Updated software
|
| ('LLVM', '20.1.5'), # for llvm-config | ||
| ] | ||
|
|
||
| dependencies = [ | ||
| ('LLVM', '20.1.5'), |
There was a problem hiding this comment.
| ('LLVM', '20.1.5'), # for llvm-config | |
| ] | |
| dependencies = [ | |
| ('LLVM', '20.1.5'), | |
| ('LLVM', '20.1.5'), # for llvm-config | |
| ] | |
| dependencies = [ |
We only need to pass LLVM once here. Since we're using static LLVM libraries, having LLVM as a build dependency only might work (if pocl isn't using stuff like libomp.so or libclang-cpp.so, which are typically not available as a static variant).
There was a problem hiding this comment.
I initially had LLVM only as dependency and not a build dependency, but then the build could not find llvm-config. Adding it as build dependency fixed that.
There was a problem hiding this comment.
That's interesting, since EasyBuild should load both the dependencies and builddependencies for the build...
I would try starting with LLVM as a build dependency only. One can then check if we need LLVM as a dependency, i.e. if some shared libraries of LLVM are still used. If that's the case, having LLVM under dependencies should theoretically be enough.
There was a problem hiding this comment.
LLVM only as build dep seems to build fine. I also don't see any dynamic linking to LLVM libs in the resulting pocl binaries
|
|
||
| source_urls = ['https://github.com/pocl/pocl/archive/'] | ||
| sources = ['v%(version)s.tar.gz'] | ||
| patches = [] |
There was a problem hiding this comment.
| patches = [] |
No need to specify patches when we don't have them 😄
|
@paulmelis could you please use the newer LLVM from #23144 ? There were two PRs for LLVM for 14.2.0, we've decided to go ahead with 23144. |
|
@paulmelis, you'll need to sync your PR with develop for the CI to (hopefully) pass. |
Tried to do it myself but i think they have some weird permission on their repo that does not allow that even if they have the check on Maintainers are allowed to edit this pull request. This applies to all other PRs from the |
|
(closed + reopened to retrigger the CI) |
|
@boegelbot please test @ jsc-zen3 |
|
Test report by @Thyre |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3285848953 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
…asyconfigs into 20250808143338_new_pr_pocl70
Co-authored-by: Jan André Reuter <jan.andre.reuter@hotmail.de>
|
@boegelbot please test @ jsc-zen3 |
|
Test report by @Crivella |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3292866486 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Going in, thanks @paulmelis! |
(created using
eb --new-pr)Depends on: