Skip to content

{tools}[GCCcore/13.3.0] ruff v0.7.0#23466

Merged
boegel merged 4 commits intoeasybuilders:developfrom
WilleBell:20250723161630_new_pr_ruff070
Oct 22, 2025
Merged

{tools}[GCCcore/13.3.0] ruff v0.7.0#23466
boegel merged 4 commits intoeasybuilders:developfrom
WilleBell:20250723161630_new_pr_ruff070

Conversation

@WilleBell
Copy link
Contributor

@WilleBell WilleBell commented Jul 23, 2025

@WilleBell WilleBell added the new label Jul 23, 2025
@WilleBell WilleBell marked this pull request as draft July 23, 2025 14:18
Copy link
Contributor

@Flamefire Flamefire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the update of easybuilders/easybuild-easyblocks#3665 this works for me

name = "lsp-types"
version = "0.95.1"
-source = "git+https://github.com/astral-sh/lsp-types.git?rev=3512a9f#3512a9f33eadc5402cfab1b8f7340824c8ca1439"
+source = "git+https://github.com/astral-sh/lsp-types.git?rev=3512a9f33eadc5402cfab1b8f7340824c8ca1439#3512a9f33eadc5402cfab1b8f7340824c8ca1439"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch shouldn't be required. The easyconfig can use ('lsp-types', '0.95.1', 'https://github.com/astral-sh/lsp-types.git', '3512a9f'), instead

We should update the cargo.py gather logic to avoid

ValueError: Found different revision in query of URL https://github.com/astral-sh/lsp-types.git: 3512a9f (expected: 3512a9f33eadc5402cfab1b8f7340824c8ca1439)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense.. I wonder if it is the same issue as here:
#21392 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, yes

@Flamefire
Copy link
Contributor

Test report by @Flamefire
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3665
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
login1.barnard.hpc.tu-dresden.de - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (sapphirerapids), Python 3.9.18
See https://gist.github.com/Flamefire/764ec3e53dfa4cd6e10fc65331af1e57 for a full test report.

@WilleBell WilleBell marked this pull request as ready for review July 23, 2025 15:19
@Thyre Thyre added the 2024a issues & PRs related to 2024a common toolchains label Aug 18, 2025
@pavelToman
Copy link
Collaborator

Test report by @pavelToman
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4002.donphan.os - Linux RHEL 9.6, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz, 1 x NVIDIA NVIDIA A2, 580.82.07, Python 3.9.21
See https://gist.github.com/pavelToman/d0f6c0dc2f9bc57da34ae11401d0c668 for a full test report.

@pavelToman
Copy link
Collaborator

Test report by @pavelToman
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4210.shinx.os - Linux RHEL 9.6, x86_64, AMD EPYC 9654 96-Core Processor, Python 3.9.21
See https://gist.github.com/pavelToman/3de587c1b148d2330dc362b3e6b798ac for a full test report.

…it's no longer needed due to improved Cargo easyblock
@boegel boegel added this to the next release (5.2.0?) milestone Oct 22, 2025
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Oct 22, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4201.shinx.os - Linux RHEL 9.6, x86_64, AMD EPYC 9654 96-Core Processor (zen4), Python 3.9.21
See https://gist.github.com/boegel/8eb04c7305f59f406bf87aee3243f0f1 for a full test report.

@boegel boegel dismissed Flamefire’s stale review October 22, 2025 08:27

requested changes made

@boegel
Copy link
Member

boegel commented Oct 22, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23466 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23466 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8518

Test results coming soon (I hope)...

Details

- notification for comment with ID 3431066204 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/0db374736c83ca35fd821bd169eccad3 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 22, 2025

Going in, thanks @WilleBell!

@boegel boegel merged commit 37073de into easybuilders:develop Oct 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2024a issues & PRs related to 2024a common toolchains new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants