{bio}[foss/2024a] dorado v1.0.2 w/ CUDA 12.6.0#23436
{bio}[foss/2024a] dorado v1.0.2 w/ CUDA 12.6.0#23436jpecar wants to merge 4 commits intoeasybuilders:developfrom
Conversation
Updated software
|
|
Can you please upload dorado-1.0.0_dont_install_external_libraries.patch, I created my own but.... I had to add this one line to builddependencies and had to remove this one line: thanks for the PR, with these few changed it built with EB 5.1.1 on Ubuntu 24.04 |
|
The maintaners will ask you to add a comment to your patch file. Then don't forget to update the checksums. |
| }, | ||
| 'filename': SOURCE_TAR_XZ, | ||
| }] | ||
| checksums = ['65e986bfc7664257b09563dceddb1dd0f4c0857af4696597d73b3bf970728db4'] |
There was a problem hiding this comment.
For me it is failing on checksums check and --inject-checksums gives me other checksum: bc44d710104b879f6982ffd4d79a8ba6c97c8aa5fefbcfd85c317d541ed1094d
|
I create a newer version of dorado based on your PR: #24328
|
| preconfigopts = "sed -i '/OPENSSL_USE_STATIC_LIBS TRUE/d' ../dorado/cmake/OpenSSL.cmake && " | ||
| # link in the ssl and crypto libs, to fix: | ||
| # undefined reference to symbol 'SSL_get_peer_certificate@@OPENSSL_1_1_0' | ||
| preconfigopts += "sed -i 's/OpenSSL::SSL/ssl\\n crypto/g' ../dorado/dorado/utils/CMakeLists.txt && " |
There was a problem hiding this comment.
| preconfigopts += "sed -i 's/OpenSSL::SSL/ssl\\n crypto/g' ../dorado/dorado/utils/CMakeLists.txt && " | |
| preconfigopts += r"sed -i 's/OpenSSL::SSL/ssl\n crypto/g' ../dorado/dorado/utils/CMakeLists.txt && " |
| @@ -0,0 +1,11 @@ | |||
| --- cmake/InstallRedistLibs.cmake.orig 2025-06-03 10:40:42.830160000 +0200 | |||
There was a problem hiding this comment.
a patch should have a description
| --- cmake/InstallRedistLibs.cmake.orig 2025-06-03 10:40:42.830160000 +0200 | |
| Use installed modules instead of external libraries | |
| Author: Jure Pečar (EMBL) | |
| --- cmake/InstallRedistLibs.cmake.orig 2025-06-03 10:40:42.830160000 +0200 |
|
I extracted |
|
|
||
| dependencies = [ | ||
| ('CUDA', '12.6.0', '', SYSTEM), | ||
| ('PyTorch', '2.6.0', '-CUDA-%(cudaver)s'), |
There was a problem hiding this comment.
Can we bump this to 2.7.1?
See:
There was a problem hiding this comment.
If memory serves, yes. But needs to be tested.
|
Is the CUDA in builddependencies really necessary for kineto? EDIT: Yes the CUDA should be in dependencies now (not builddeps): #25146 |
|
|
||
| name = 'kineto' | ||
| version = '20250715' | ||
| local_commit = '16e2a56' |
There was a problem hiding this comment.
| local_commit = '16e2a56' | |
| local_commit = '16e2a56' | |
| versionsuffix = '-CUDA-%(cudaver)s' |
Should we add the version suffix because CUDA is a build dependency? For easybuild-easyconfigs/easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.4.0-GCC-13.3.0-CUDA-12.6.0.eb we did.
There was a problem hiding this comment.
That's being dealt with in:
|
@jpecar I think we should just go ahead with:
|
|
Fine with me. |
(created using
eb --new-pr)