add libffi as direct dependency in recent LLVM easyconfigs

[Crivella]

Companion PR to

• add explicit enabling/disabling of libffi with custom paths in LLVM easyblock easybuild-easyblocks#3849

Notes

• libffi was already an indirect dependency but this future proofs it and makes it clear it is also a dependency
• Removed the skip_mod_files_sanity_check option as it is now being set by the EasyBlock when needed
• Even if the linked issue is related to offload which has been introduced since LLVM >= 19 the added configure options are also available for 18.1.8

[boegelbot]

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3849
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/b9ec75d5de315a6974d83c5997c76978 for a full test report.

[Crivella]

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr-23429 --include-easyblocks-from-pr 3849"
CORE_CNT=16

[boegelbot]

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23429 EB_ARGS="--installpath /tmp/$USER/pr-23429 --include-easyblocks-from-pr 3849" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23429 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

• exit code: 0
• output:

Submitted batch job 7271

Test results coming soon (I hope)...

Details

- notification for comment with ID 3078300397 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

[boegelbot]

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3849
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/5ad479af7da963a53922c11d91df5a63 for a full test report.

[bartoldeman]

Test report for LLVM-20.1.5-GCCcore-13.3.0.eb
https://gist.github.com/bartoldeman/ad4001205949db39be05bf186e80f356

two notes:

• I tweaked the easyblock a bit to not include the GCC lib dir into LD_LIBRARY_PATH, as that breaks in our somewhat unusual setup (using GCC from Gentoo prefix).
• I raised the number of allowed test failures to 50 as a precaution and got:
  Test suite completed with 29 failed tests (50 allowed)

[ocaisa]

LGTM