Skip to content

add patch to fix failing OCSP stapling test for IO::Socket::SSL extension in Perl-bundle-CPAN easyconfigs#23030

Merged
Crivella merged 1 commit intoeasybuilders:developfrom
lorisercole:fix/Perl-bundle-CPAN-OCSP-test
Jun 6, 2025
Merged

add patch to fix failing OCSP stapling test for IO::Socket::SSL extension in Perl-bundle-CPAN easyconfigs#23030
Crivella merged 1 commit intoeasybuilders:developfrom
lorisercole:fix/Perl-bundle-CPAN-OCSP-test

Conversation

@lorisercole
Copy link
Contributor

The OCSP stapling tests run by the IO::Socket::SSL extension of Perl-bundle-CPAN started failing due to a change of behavior of the server contacted by these tests (see noxxi/p5-io-socket-ssl#169).
A patch derived from noxxi/p5-io-socket-ssl@58ad1d1 is applied to avoid this issue.

@github-actions github-actions bot added the change label Jun 4, 2025
@lorisercole lorisercole changed the title Fix Perl-bundle-CPAN IO::Socket::SSL failing test Fix Perl-bundle-CPAN IO::Socket::SSL failing tests Jun 4, 2025
@Crivella
Copy link
Contributor

Crivella commented Jun 4, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr23030"

@Crivella Crivella added this to the next release (5.1.1?) milestone Jun 4, 2025
@boegelbot
Copy link
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23030 EB_ARGS="--installpath /tmp/$USER/pr23030" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23030 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6603

Test results coming soon (I hope)...

Details

- notification for comment with ID 2940094302 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@lorisercole lorisercole force-pushed the fix/Perl-bundle-CPAN-OCSP-test branch from 864d46e to fc2ab8f Compare June 4, 2025 14:09
The OCSP stapling tests run by the `IO::Socket::SSL` extension of
`Perl-bundle-CPAN` started failing due to a change of behavior of
the server contacted by these tests (see
noxxi/p5-io-socket-ssl#169).
A patch derived from noxxi/p5-io-socket-ssl@58ad1d1
is applied to avoid this issue.
@lorisercole lorisercole force-pushed the fix/Perl-bundle-CPAN-OCSP-test branch from fc2ab8f to df47393 Compare June 4, 2025 14:29
@Crivella
Copy link
Contributor

Crivella commented Jun 4, 2025

Test report by @Crivella
SUCCESS
Build succeeded for 6 out of 6 (4 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.12
See https://gist.github.com/Crivella/006555d8c90f0ce09515562f134e7547 for a full test report.

@sassy-crick
Copy link
Collaborator

Test report by @sassy-crick
FAILED
Build succeeded for 1 out of 4 (4 easyconfigs in total)
hp - Linux Debian GNU/Linux 12, x86_64, 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz, Python 3.11.2
See https://gist.github.com/sassy-crick/05f41f8bcc2819818481a01dbc393ad7 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/6a19099185c8b1c85adaaa7f205b2f7c for a full test report.

@sassy-crick
Copy link
Collaborator

Strangely enough, it all works on our RHEL-8 cluster with the full test report being here

Test result

Build succeeded for 6 out of 6

Overview of tested easyconfigs (in order)

  • SUCCESS Perl-bundle-CPAN-5.36.1-GCCcore-12.3.0.eb
  • SUCCESS Perl-bundle-CPAN-5.38.0-GCCcore-13.2.0.eb
  • SUCCESS Perl-bundle-CPAN-5.38.2-GCCcore-13.3.0.eb
  • SUCCESS groff-1.23.0-GCCcore-14.2.0.eb
  • SUCCESS expat-2.6.4-GCCcore-14.2.0.eb
  • SUCCESS Perl-bundle-CPAN-5.40.0-GCCcore-14.2.0.eb

Time info

  • start: Wed, 04 Jun 2025 16:15:33 +0000 (UTC)
  • end: Wed, 04 Jun 2025 20:58:08 +0000 (UTC)

EasyBuild info

  • easybuild-framework version: 5.1.0
  • easybuild-easyblocks version: 5.1.0
  • command line:
eb --robot --download-timeout=100 --hooks=/rds/easybuild/hooks/cx3-phase2-hooks.py --rebuild --dump-test-report=/rds/general/user/jsassman/home/easybuild/perl-testbuild/report.md --from-pr 23030

@Crivella
Copy link
Contributor

Crivella commented Jun 5, 2025

I think there is quite a bit of flakiness in the tests.
The one failing with the bot does not seem related to this at all (IO::Sockect::INET seems to be part of Perl itself while IO::Scoket::SSL is a separate package on github).

t/base/ua_handlers.t ........... ok

#   Failed test 'leaks 4866 <= 0'
#   at t/leak/no_leak.t line 22.
#     '4866'
#         <=
#     '0'
# leaked SCALAR(0x162cfb8) from /tmp/boegelbot/pr23030/software/Perl-bundle-CPAN/5.38.0-GCCcore-13.2.0/lib/perl5/site_perl/5.38.0/HTTP/Message.pm line 46.
#   45:    else {
#   46:	$header = HTTP::Headers->new;
#   47:    }
# SV = IV(0x162cfa8) at 0x162cfb8
#   REFCNT = 1
#   FLAGS = (IOK,pIOK)
#   IV = 19658712
# leaked SCALAR(0x162cc40) from /tmp/boegelbot/PerlbundleCPAN/5.38.0/GCCcore-13.2.0/LWPSimple/libwww-perl-6.72/blib/lib/LWP/UserAgent.pm line 1209.
# 1208:    $message ||= HTTP::Status::status_message($code);
# 1209:    my $response = HTTP::Response->new($code, $message);
# 1210:    $response->request($request);
# SV = IV(0x162cc30) at 0x162cc40
#   REFCNT = 1
#   FLAGS = (IOK,pIOK)
#   IV = 21012304
# Looks like you failed 1 test of 1.
t/leak/no_leak.t ............... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
t/local/autoload-get.t ......... ok
t/local/autoload.t ............. ok

@Crivella
Copy link
Contributor

Crivella commented Jun 6, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr23030 Perl-bundle-CPAN-5.38.0-GCCcore-13.2.0.eb"

@boegelbot
Copy link
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23030 EB_ARGS="--installpath /tmp/$USER/pr23030 Perl-bundle-CPAN-5.38.0-GCCcore-13.2.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23030 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6621

Test results coming soon (I hope)...

Details

- notification for comment with ID 2948954049 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/cf879d3896a36af435ec3e4f4ea7991c for a full test report.

@Crivella
Copy link
Contributor

Crivella commented Jun 6, 2025

So #23030 (comment) is the test build that previously failed in #23030 (comment)

I think there is some serious flakyness in this tests but that is unrelated to this PR which is only applying the upstream patch to disable the OCSP test, i would be prone to merge this as is

Copy link
Contributor

@Crivella Crivella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checked that the fingerprint has always been the same since 8 years ago, so no trouble using the same patch for all versions.

LGTM

@Crivella
Copy link
Contributor

Crivella commented Jun 6, 2025

Going in, thanks @lorisercole!

@Crivella Crivella merged commit 2d83e1d into easybuilders:develop Jun 6, 2025
8 checks passed
@boegel boegel changed the title Fix Perl-bundle-CPAN IO::Socket::SSL failing tests add patch to fix failing OCSP stapling test for IO::Socket::SSL extension in Perl-bundle-CPAN easyconfigs Jun 6, 2025
@lorisercole lorisercole deleted the fix/Perl-bundle-CPAN-OCSP-test branch June 19, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants