Skip to content

add patch to fix ml_dtypes 0.5.0 on AVX512 CPUs with FP16 support#22919

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20250520162503_new_pr_ml_dtypes050
May 20, 2025
Merged

add patch to fix ml_dtypes 0.5.0 on AVX512 CPUs with FP16 support#22919
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20250520162503_new_pr_ml_dtypes050

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented May 20, 2025

(created using eb --new-pr)

This is a known issue in Eigen which is fixed in newer versions.

Requires:

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
login1.barnard.hpc.tu-dresden.de - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/aecf8d6799118675386ca1f642c81493 for a full test report.

@boegel boegel changed the title Fix ml_dtypes on AVX512 CPUs with FP16 support add patch to fix ml_dtypes 0.5.0 on AVX512 CPUs with FP16 support May 20, 2025
@boegel boegel added bug fix and removed change labels May 20, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented May 20, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22919 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22919 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6406

Test results coming soon (I hope)...

Details

- notification for comment with ID 2895280936 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/8f8428712f7018594b5000b2c1a63b7b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 20, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3505.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/54d60a080ca3bbf7cebc57177e3877c2 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 20, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4227.shinx.os - Linux RHEL 9.4, x86_64, AMD EPYC 9654 96-Core Processor (zen4), Python 3.9.18
See https://gist.github.com/boegel/4505a6f4fde37f2a4395854322b545e4 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 20, 2025

Going in, thanks @Flamefire!

@boegel boegel merged commit 4381b95 into easybuilders:develop May 20, 2025
8 checks passed
@Flamefire Flamefire deleted the 20250520162503_new_pr_ml_dtypes050 branch May 21, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants