Skip to content

avoid using buildcmd in PySide2 easyconfig#22380

Merged
branfosj merged 1 commit intoeasybuilders:5.0.xfrom
boegel:20250224172342_new_pr_PySide251423
Feb 27, 2025
Merged

avoid using buildcmd in PySide2 easyconfig#22380
branfosj merged 1 commit intoeasybuilders:5.0.xfrom
boegel:20250224172342_new_pr_PySide251423

Conversation

@boegel
Copy link
Member

@boegel boegel commented Feb 24, 2025

(created using eb --new-pr)

related to proposal to deprecate the confusing buildcmd custom easyconfig parameter in PythonPackage easyblock, see easybuilders/easybuild-easyblocks#3575

@boegel boegel added this to the 4.x milestone Feb 24, 2025
@boegel
Copy link
Member Author

boegel commented Feb 24, 2025

@boegelbot please test @ jsc-zen3

@boegel boegel changed the title avoid using buildcmd in PySide2 easyconfig avoid using buildcmd in PySide2 easyconfig Feb 24, 2025
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22380 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22380 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5769

Test results coming soon (I hope)...

Details

- notification for comment with ID 2678995718 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 11 out of 26 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/0dc3664d1796c60cda591f07fbf9551c for a full test report.

@boegel boegel requested a review from Micket February 24, 2025 19:34
@Micket
Copy link
Contributor

Micket commented Feb 24, 2025

did you mean to target 5.0.x?

@boegel boegel changed the base branch from develop to 5.0.x February 26, 2025 08:19
@boegel boegel force-pushed the 20250224172342_new_pr_PySide251423 branch from 5955f70 to fc7afc7 Compare February 26, 2025 08:20
@boegel
Copy link
Member Author

boegel commented Feb 26, 2025

did you mean to target 5.0.x?

Yes, fixed just now with force push

@boegel
Copy link
Member Author

boegel commented Feb 26, 2025

@boegelbot please test @ jsc-zen3
EB_BRANCH=5.0.x

@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Feb 26, 2025
@boegel boegel modified the milestones: 4.x, 5.0.0 Feb 26, 2025
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=22380 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_22380 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5794

Test results coming soon (I hope)...

Details

- notification for comment with ID 2684252574 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 15 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/05f62728c819935ddbcf9c7f107c8039 for a full test report.

@Micket
Copy link
Contributor

Micket commented Feb 27, 2025

Probably not much hope in even testing this. What do you wish to do with it?

@branfosj
Copy link
Member

Probably not much hope in even testing this. What do you wish to do with it?

I think I have all the deps built, so will try a test build. If it does work them I'm happy to merge.

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/fe65dbcc241b2c9ff9d36990ad8f7a75 for a full test report.

@branfosj branfosj merged commit a5b5d9d into easybuilders:5.0.x Feb 27, 2025
8 checks passed
@boegel boegel deleted the 20250224172342_new_pr_PySide251423 branch February 28, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants