Skip to content

add patch to enable installing GLib typelibs for GObject-Introspection 1.80.1#22309

Merged
boegel merged 5 commits intoeasybuilders:developfrom
Flamefire:20250214084730_new_pr_GObject-Introspection1801
Aug 18, 2025
Merged

add patch to enable installing GLib typelibs for GObject-Introspection 1.80.1#22309
boegel merged 5 commits intoeasybuilders:developfrom
Flamefire:20250214084730_new_pr_GObject-Introspection1801

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Feb 14, 2025

(created using eb --new-pr)

GObject-Introspection 1.79+ does no longer install the GIR and typelib files of GLib, see https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/517

This PR reverts the commit that disables installing the typelib files similar to #21385 which re-enabled installing the gir files.

Both combined should restore the pre-1.79 behavior until there is a better solution.

Summary of the issue:

  • To get the GLib gir/typelib files GLib needs to be build with with -Dintrospection=enabled and gobject-introspection as a dependency
  • gobject-introspection has GLib as an indirect dependency (it depends on Cairo which depends on GLib)
  • The suggested approach by the maintainers is to build GLib twice which I don't see a good way to do in EB without merging GLib, Cairo and GObject-Introspection into one EC
  • There is an open issue upstream to merge GLib and GObject-Introspection into a single entity but that hasn't happened yet.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
i7011 - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17
See https://gist.github.com/Flamefire/490f6153d9b01d03831168b29eef8588 for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Feb 14, 2025

Do we want to extend the sanity check to make sure those libraries are present?

@SebastianAchilles SebastianAchilles added this to the release after 4.9.4 milestone Feb 14, 2025
@SebastianAchilles
Copy link
Copy Markdown
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bwd-rockylinux-95 - Linux Rocky Linux 9.5 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), 2 x NVIDIA NVIDIA GeForce GTX 1060 6GB, 535.216.03, Python 3.9.21
See https://gist.github.com/SebastianAchilles/58eced1188df2e957a1478a0a3b5d173 for a full test report.

@boegel boegel modified the milestones: release after 4.9.4, release after 5.0.0 Mar 18, 2025
@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
i7044 - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17
See https://gist.github.com/Flamefire/7f34887a33d123d1dc509bdc95f736d3 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
n1104 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/bc518f0a7035a4f0914734073199b32b for a full test report.

@boegel boegel modified the milestones: next release (5.1.0), 5.x May 23, 2025
@Thyre Thyre added bug fix 2024a issues & PRs related to 2024a common toolchains and removed change labels Aug 18, 2025
@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Aug 18, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath=/tmp/$USER/ecpr-22309"

@boegelbot
Copy link
Copy Markdown
Collaborator

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22309 EB_ARGS="--installpath=/tmp/$USER/ecpr-22309" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22309 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7643

Test results coming soon (I hope)...

Details

- notification for comment with ID 3196808710 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/edd93266453f33312f07c143186a31f1 for a full test report.

@boegel boegel changed the title Install GLib typelibs for GObject-Introspection-1.80.1 add patch to enable installing GLib typelibs for GObject-Introspection 1.80.1 Aug 18, 2025
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 18, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22309 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22309 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7671

Test results coming soon (I hope)...

Details

- notification for comment with ID 3197580684 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 18, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3555.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/2b53670febd05aca618aed67989cce60 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/89929af215432c2aae62230a9ee7d14e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 18, 2025

Going in, thanks @Flamefire!

@boegel boegel merged commit 141ef7b into easybuilders:develop Aug 18, 2025
8 checks passed
@boegel boegel modified the milestones: 5.x, next release (5.1.2) Aug 18, 2025
@Flamefire Flamefire deleted the 20250214084730_new_pr_GObject-Introspection1801 branch August 24, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2024a issues & PRs related to 2024a common toolchains bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants