Skip to content

add patch for OpenMPI v5.0.3 to fix C90 compliance#22006

Merged
boegel merged 2 commits intoeasybuilders:developfrom
maxim-masterov:ompi_upd_2024a
May 24, 2025
Merged

add patch for OpenMPI v5.0.3 to fix C90 compliance#22006
boegel merged 2 commits intoeasybuilders:developfrom
maxim-masterov:ompi_upd_2024a

Conversation

@maxim-masterov
Copy link
Copy Markdown
Collaborator

This patch fixes the issue described in open-mpi/ompi#12710. It is fully based on (merged) PR open-mpi/ompi#12830.

Without this patch some applications (e.g. ParaView) cannot be build due to emerge of the following error:

/path/to/software/2024a/opt/gcc-11.3.0/openmpi/5.0.2+ucx-1.15.0/include/mpi_portable_platform.h:294:30: error: operator '/' has no right operand
  294 | #elif defined(__NVCOMPILER) // Must occur prior to PGI and CLANG

@paulmelis
Copy link
Copy Markdown
Contributor

Any news on this patch?

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title [UPD] Patch OpenMPI v5.0.3 for C90 compliance add patch for OpenMPI v5.0.3 to fix C90 compliance May 24, 2025
@boegel boegel added this to the next release (5.1.0) milestone May 24, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented May 24, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr22006"

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22006 EB_ARGS="--installpath /tmp/$USER/pr22006" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22006 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6476

Test results coming soon (I hope)...

Details

- notification for comment with ID 2906609878 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented May 24, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3564.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/efc4bbabbdb705ea308d797f78a8030b for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/a5b1942647ddb4f3112c83966ad2538e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 24, 2025

Going in, thanks @maxim-masterov!

@boegel boegel merged commit 681da61 into easybuilders:develop May 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants