use pycodestyle for code style check + stop using l in list comprehensions#21502
Merged
jfgrimm merged 4 commits intoeasybuilders:5.0.xfrom Sep 30, 2024
Merged
use pycodestyle for code style check + stop using l in list comprehensions#21502jfgrimm merged 4 commits intoeasybuilders:5.0.xfrom
l in list comprehensions#21502jfgrimm merged 4 commits intoeasybuilders:5.0.xfrom
Conversation
framework uses pycodestyle if available and pep8 only as a fallback and later likely not at all (pep8 was renamed to pycodestyle and the existing package is no longer updated) So we need to check for either both or (more future proof) only for pycodestyle.
pep8 has bugs which makes it miss many issues like long-lines in docstrings. This might make the tests fail if both packages are available as framework prefers the newer pycodestyle.
…riable name reported by pycodestyle
This was referenced Sep 30, 2024
Flamefire
reviewed
Oct 1, 2024
Comment on lines
+6
to
+9
| description = """FreeSurfer is a set of tools for analysis and visualization | ||
| of structural and functional brain imaging data. FreeSurfer contains a fully | ||
| automatic structural imaging stream for processing cross sectional and | ||
| longitudinal data.""" |
Contributor
There was a problem hiding this comment.
Note that this changes the module help text. I used the following for IMO more sensible line breaks in #21405
description = """\
FreeSurfer is a set of tools for analysis and visualization of structural and functional brain imaging data.
FreeSurfer contains a fully automatic structural imaging stream for processing cross sectional and longitudinal data.
"""
If that sounds useful I can do the Search&replace using the texts I previously used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.