Skip to content

Add some more packages to R-bundle-CRAN-2024.06-foss-2023b#21181

Closed
Flamefire wants to merge 5 commits intoeasybuilders:developfrom
Flamefire:add-R-bundle-pkgs
Closed

Add some more packages to R-bundle-CRAN-2024.06-foss-2023b#21181
Flamefire wants to merge 5 commits intoeasybuilders:developfrom
Flamefire:add-R-bundle-pkgs

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

Extracted the remaining change from #20756 after that got missed when merging #20898

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
i7003 - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17
See https://gist.github.com/Flamefire/3371ede393336858db2faef2f24abbb3 for a full test report.

@PhoenixEmik
Copy link
Copy Markdown
Contributor

I believe these packages exist in R-4.4.1-gfbf-2023b. I wonder why they need to be added to R-bundle-CRAN-2024.06-foss-2023b duplicately?

@Thyre Thyre added the 2023b label Aug 18, 2025
@Flamefire
Copy link
Copy Markdown
Contributor Author

You are right, not needed.

@Thyre Should the 2023b etc. label maybe moved to the bot to add it automatically?

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Aug 25, 2025

@Thyre Should the 2023b etc. label maybe moved to the bot to add it automatically?

I think that this would generally be a good idea, yeah. However, if I remember discussions correctly, we want to avoid parsing EasyConfigs in our labeling job due to permissions, so we would need to do this via file names only.

@Flamefire
Copy link
Copy Markdown
Contributor Author

we want to avoid parsing EasyConfigs in our labeling job due to permissions, so we would need to do this via file names only.

Isn't the parsing already happening when searching for related easyconfigs?

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Aug 25, 2025

Isn't the parsing already happening when searching for related easyconfigs?

No, it is searching based on the parent folder of the EasyConfig, and uses git.Repo to compare the files.
See https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/.github/workflows/tagbot.py

@Flamefire Flamefire closed this Aug 26, 2025
@Flamefire Flamefire deleted the add-R-bundle-pkgs branch August 26, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants