whitelist ConfigureMakePythonPackage for sanity_check_paths CI check#20963
Merged
Micket merged 2 commits intoeasybuilders:developfrom Jul 7, 2024
Merged
Conversation
Flamefire
force-pushed
the
whitelist-configuremakepython
branch
from
18b4d8f to
d9889cc
Compare
1 task
Micket
approved these changes
Jul 7, 2024
Contributor
Micket
left a comment
Micket
left a comment
There was a problem hiding this comment.
lgtm, though this should be cleaned up further for 5.0.x where we no longer have 2016[ab]
Contributor
Author
Right. But as long as the configparser check for 2016 is there it is now "complete". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also extend the
sanity_pip_checkwhitelist for all 2016 ECs although this won't really matter going forward. Just kept that commit as long as that check is there