-
Notifications
You must be signed in to change notification settings - Fork 782
{GCCcore/12.3.0} Unify Z3 4.12.2 easyconfigs into a single one with Python bindings (and fix Z3 dependency for PyTorch 2.1.2 accordingly) #20050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Micket
merged 1 commit into
easybuilders:develop
from
lexming:20240306115047_new_pr_Z34122
Mar 13, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 0 additions & 53 deletions
53
easybuild/easyconfigs/z/Z3/Z3-4.12.2-GCCcore-12.3.0-Python-3.11.3.eb
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,51 @@ | ||
| easyblock = 'CMakeMake' | ||
| easyblock = 'PythonBundle' | ||
|
|
||
| name = 'Z3' | ||
| version = '4.12.2' | ||
|
|
||
| homepage = 'https://github.com/Z3Prover/z3' | ||
| description = """ | ||
| Z3 is a theorem prover from Microsoft Research. | ||
| description = """Z3 is a theorem prover from Microsoft Research with support for bitvectors, | ||
| booleans, arrays, floating point numbers, strings, and other data types. This | ||
| module includes z3-solver, the Python interface of Z3. | ||
| """ | ||
|
|
||
| toolchain = {'name': 'GCCcore', 'version': '12.3.0'} | ||
|
|
||
| source_urls = ['https://github.com/Z3Prover/z3/archive/'] | ||
| sources = [SOURCELOWER_TAR_GZ] | ||
| checksums = [ | ||
| {'z3-4.12.2.tar.gz': '9f58f3710bd2094085951a75791550f547903d75fe7e2fcb373c5f03fc761b8f'}, | ||
| ] | ||
|
|
||
| builddependencies = [ | ||
| ('CMake', '3.26.3'), | ||
| ('binutils', '2.40'), | ||
| ] | ||
|
|
||
| dependencies = [ | ||
| ('Python', '3.11.3'), | ||
| ('GMP', '6.2.1'), | ||
| ] | ||
|
|
||
| configopts = '-DZ3_USE_LIB_GMP=ON -DZ3_LINK_TIME_OPTIMIZATION=ON ' | ||
| use_pip = True | ||
|
|
||
| _fix_parallelism = """sed -i 's/str(multiprocessing.cpu_count())/"%(parallel)s"/' setup.py && """ | ||
| _enable_gmp = """sed -i "s/Z3_USE_LIB_GMP.*/Z3_USE_LIB_GMP' : True,/" setup.py && """ | ||
|
|
||
| exts_list = [ | ||
| ('z3-solver', version + '.0', { | ||
| 'modulename': 'z3', | ||
| 'checksums': ['65ab47a0a8ef0bfb80db0670775beb11b32c3c0ae4b35943e44121f4af7ef411'], | ||
| 'preinstallopts': _fix_parallelism + _enable_gmp, | ||
| }), | ||
| ] | ||
|
|
||
| # make Z3 headers and libraries accessible in their usual location | ||
| local_z3_site_path = "lib/python%(pyshortver)s/site-packages/%(namelower)s" | ||
| postinstallcmds = [ | ||
| 'ln -s %s/include "%%(installdir)s/include"' % local_z3_site_path, | ||
| 'cd "%%(installdir)s"; for lib in %s/lib/*; do ln -s ../$lib lib/$(basename $lib); done' % local_z3_site_path | ||
| ] | ||
|
|
||
| sanity_pip_check = True | ||
|
|
||
| sanity_check_paths = { | ||
| 'files': ['bin/z3', 'include/z3_api.h', 'lib/libz3.%s' % SHLIB_EXT], | ||
| 'dirs': [], | ||
| 'dirs': ['include', 'lib/python%(pyshortver)s/site-packages'], | ||
| } | ||
|
|
||
| moduleclass = 'tools' | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason this is a Python* Bundle* not a PythonPackage ? It only has a (single) Pythonpackage, doesn't it?
Maybe we can change/fix that in a followup. It just sticks out here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Flamefire because then
z3-solveris shown as an extension of the Z3 module, in case users search specifically for that name