Skip to content

{lib,tools}[foss/2023a] Lightning v2.2.1 w/ CUDA 12.1.1#19964

Merged
smoors merged 8 commits intoeasybuilders:developfrom
NPotvin:20240223163821_new_pr_PyTorch-Lightning220post0
May 5, 2024
Merged

{lib,tools}[foss/2023a] Lightning v2.2.1 w/ CUDA 12.1.1#19964
smoors merged 8 commits intoeasybuilders:developfrom
NPotvin:20240223163821_new_pr_PyTorch-Lightning220post0

Conversation

@NPotvin
Copy link
Contributor

@NPotvin NPotvin commented Feb 23, 2024

…1.1.eb, lightning-2.2.0.post0-foss-2023a-PyTorch-2.1.2-CUDA-12.1.1.eb
@NPotvin
Copy link
Contributor Author

NPotvin commented Feb 23, 2024

To make it work, I used --from-pr 19666,19648 for the ECs of PyTorch, deepdiff and tensordboardX

@easybuilders easybuilders deleted a comment from boegelbot Feb 27, 2024
@boegel boegel changed the title {lib,tools}[foss/2023a] PyTorch-Lightning v2.2.0.post0, lightning v2.2.0.post0 w/ CUDA 12.1.1, PyTorch 2.1.2 CUDA 12.1.1 {lib,tools}[foss/2023a] PyTorch-Lightning v2.2.0.post0 w/ CUDA 12.1.1, tensorboardX v2.6.2.2, deepdiff v6.7.1 Feb 27, 2024
boegel
boegel previously requested changes Feb 27, 2024
@NPotvin NPotvin changed the title {lib,tools}[foss/2023a] PyTorch-Lightning v2.2.0.post0 w/ CUDA 12.1.1, tensorboardX v2.6.2.2, deepdiff v6.7.1 {lib,tools}[foss/2023a] PyTorch-Lightning v2.2.0.post0 w/ CUDA 12.1.1 Feb 29, 2024
@NPotvin NPotvin requested a review from boegel February 29, 2024 15:49
@smoors
Copy link
Contributor

smoors commented Mar 11, 2024

@NPotvin PyTorch-Lightning has been updated to v2.2.1 in #19648
i much prefer you use that version as dep for Lightning (and probably update it to v2.2.1 also)
or do you have a specific reason for using v2.2.0.post0 ?

@NPotvin
Copy link
Contributor Author

NPotvin commented Mar 11, 2024

@smoors Thanks for reviewing this PR !
Version 2.2.1 was released last week. That's the reason for 2.2.0.post0.
I won't have the time to deal with it today, but I'll go through your comments tomorrow and change my PR accordingly, including upgrading to 2.2.1.

@NPotvin NPotvin changed the title {lib,tools}[foss/2023a] PyTorch-Lightning v2.2.0.post0 w/ CUDA 12.1.1 {lib,tools}[foss/2023a] PyTorch-Lightning v2.2.1 w/ CUDA 12.1.1 Mar 12, 2024
@boegel
Copy link
Member

boegel commented May 4, 2024

@smoors Is this good to merge?

@smoors smoors changed the title {lib,tools}[foss/2023a] PyTorch-Lightning v2.2.1 w/ CUDA 12.1.1 {lib,tools}[foss/2023a] Lightning v2.2.1 w/ CUDA 12.1.1 May 5, 2024
@smoors
Copy link
Contributor

smoors commented May 5, 2024

@NPotvin i removed the PyTorch versionsuffix, as v2.1.2 is already the default version for the 2023a toolchain generation.

@smoors
Copy link
Contributor

smoors commented May 5, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=19964 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19964 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13402

Test results coming soon (I hope)...

Details

- notification for comment with ID 2094667276 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c624cea6801dcf82f24c092669091cd7 for a full test report.

@smoors
Copy link
Contributor

smoors commented May 5, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19964 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19964 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4066

Test results coming soon (I hope)...

Details

- notification for comment with ID 2094673519 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/ce2755c4cd8d0cc468871904df3faf1b for a full test report.

@smoors smoors modified the milestones: 4.x, release after 4.9.1 May 5, 2024
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors dismissed boegel’s stale review May 5, 2024 15:02

changes done

@smoors
Copy link
Contributor

smoors commented May 5, 2024

Going in, thanks @NPotvin!

@smoors smoors merged commit 4f342d1 into easybuilders:develop May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants