Skip to content

{compiler,tools}[GCCcore/13.2.0] Clang v17.0.6#19776

Merged
boegel merged 3 commits intoeasybuilders:developfrom
bartoldeman:20240201133507_new_pr_Z34125
Jun 8, 2024
Merged

{compiler,tools}[GCCcore/13.2.0] Clang v17.0.6#19776
boegel merged 3 commits intoeasybuilders:developfrom
bartoldeman:20240201133507_new_pr_Z34125

Conversation

@bartoldeman
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@bartoldeman
Copy link
Copy Markdown
Contributor Author

@boegelbot please test @ generoso

@bartoldeman bartoldeman added this to the release after 4.9.0 milestone Feb 1, 2024
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Feb 1, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19776 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19776 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3542

Test results coming soon (I hope)...

Details

- notification for comment with ID 1921442982 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 1, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19776 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19776 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12807

Test results coming soon (I hope)...

Details

- notification for comment with ID 1921540077 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/05a8ce89adbd3606f716f7454b70c65e for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/336dc209c0a036eea0402d067c53b2f1 for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor Author

Note that enable_rtti = False disables both RTTI and exception handling in the easyblock:

    if self.cfg["enable_rtti"]:
            self.cfg.update('configopts', '-DLLVM_REQUIRES_RTTI=ON')
            self.cfg.update('configopts', '-DLLVM_ENABLE_RTTI=ON')
            self.cfg.update('configopts', '-DLLVM_ENABLE_EH=ON')

but for flang we only need to skip '-DLLVM_ENABLE_EH=ON' (see e.g. the spack package: https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/llvm/package.py) and can keep RTTI without exception handling.

this would need a change to the easyblock, either
a) a new option "enable_eh" seperate from "enable_rtti"
or
b) like Spack:

    if self.cfg["enable_rtti"]:
        self.cfg.update('configopts', '-DLLVM_REQUIRES_RTTI=ON')
        self.cfg.update('configopts', '-DLLVM_ENABLE_RTTI=ON')
        if 'flang' not in self.cfg['llvm_projects'] or version < '15':
            self.cfg.update('configopts', '-DLLVM_ENABLE_EH=ON')

@ocaisa what do you think as author of that part of the easyblock?

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Feb 2, 2024

@bartoldeman if it works, I'm fine with it. I only disabled those to get a functional build, I have no real understanding of the impact

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 6, 2024

Changes in #20050 are relevant to this PR.

@boegel boegel modified the milestones: 4.9.1, release after 4.9.1 Apr 3, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2024

Note that enable_rtti = False disables both RTTI and exception handling in the easyblock:

    if self.cfg["enable_rtti"]:
            self.cfg.update('configopts', '-DLLVM_REQUIRES_RTTI=ON')
            self.cfg.update('configopts', '-DLLVM_ENABLE_RTTI=ON')
            self.cfg.update('configopts', '-DLLVM_ENABLE_EH=ON')

but for flang we only need to skip '-DLLVM_ENABLE_EH=ON' (see e.g. the spack package: https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/llvm/package.py) and can keep RTTI without exception handling.

this would need a change to the easyblock, either a) a new option "enable_eh" seperate from "enable_rtti" or b) like Spack:

    if self.cfg["enable_rtti"]:
        self.cfg.update('configopts', '-DLLVM_REQUIRES_RTTI=ON')
        self.cfg.update('configopts', '-DLLVM_ENABLE_RTTI=ON')
        if 'flang' not in self.cfg['llvm_projects'] or version < '15':
            self.cfg.update('configopts', '-DLLVM_ENABLE_EH=ON')

@ocaisa what do you think as author of that part of the easyblock?

@bartoldeman Are you up for opening a PR for this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2024

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19776 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19776 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13678

Test results coming soon (I hope)...

Details

- notification for comment with ID 2155872068 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2024

@boegelbot please test @ jsc-zen3
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19776 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19776 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4330

Test results coming soon (I hope)...

Details

- notification for comment with ID 2155898991 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/3ea4ec11611b746ccd522b710e05c0b6 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/1e8763ece50657ef52b6d45ec5a51128 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3117.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/b1bf4dce3f374209d53849eb6954ba93 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title {compiler,tools}[GCCcore/13.2.0] Z3 v4.12.5, Clang v17.0.6 {compiler,tools}[GCCcore/13.2.0] Clang v17.0.6 Jun 8, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2024

Going in, thanks @bartoldeman!

@boegel boegel merged commit 58ae57e into easybuilders:develop Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants