Skip to content

demote meson-python to a build dependency in recent matplotlib easyconfigs#19670

Merged
bedroge merged 1 commit intoeasybuilders:developfrom
jfgrimm:20240122122334_new_pr_matplotlib372
Jan 29, 2024
Merged

demote meson-python to a build dependency in recent matplotlib easyconfigs#19670
bedroge merged 1 commit intoeasybuilders:developfrom
jfgrimm:20240122122334_new_pr_matplotlib372

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Jan 22, 2024

meson(-python) is not a runtime requirement for maplotlib

(created using eb --new-pr)

@jfgrimm jfgrimm added this to the release after 4.9.0 milestone Jan 22, 2024
@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Jan 22, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19670 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19670 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12687

Test results coming soon (I hope)...

Details

- notification for comment with ID 1903899503 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/b88bb72d317343e4cf8160d1c7370813 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Jan 22, 2024

@boegelbot: please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19670 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19670 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3448

Test results coming soon (I hope)...

Details

- notification for comment with ID 1904196778 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 34 out of 34 (2 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/24317d35490aa6f0fbf814c658f09336 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Jan 24, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 25 out of 25 (2 easyconfigs in total)
node075.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/482b4fb8577c28a5151f679688f27e50 for a full test report.

Copy link
Copy Markdown
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Jan 29, 2024

Going in, thanks @jfgrimm!

@bedroge bedroge merged commit 7bf6669 into easybuilders:develop Jan 29, 2024
@boegel boegel changed the title demote meson-python to a build dep in matplotlib demote meson-python to a build dep in recent matplotlib easyconfigs Jan 31, 2024
@boegel boegel changed the title demote meson-python to a build dep in recent matplotlib easyconfigs demote meson-python to a build dependency in recent matplotlib easyconfigs Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants