Skip to content

add -DABSL_PROPAGATE_CXX_STD=ON to recent Abseil easyconfigs (required for PyTorch)#18413

Merged
casparvl merged 1 commit intoeasybuilders:developfrom
Flamefire:20230728142131_new_pr_Abseil202103242
Aug 1, 2023
Merged

add -DABSL_PROPAGATE_CXX_STD=ON to recent Abseil easyconfigs (required for PyTorch)#18413
casparvl merged 1 commit intoeasybuilders:developfrom
Flamefire:20230728142131_new_pr_Abseil202103242

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jul 28, 2023

(created using eb --new-pr)

This is required for e.g. PyTorch which otherwise fails to build with GCC 12 as the C++ standard flag isn't set correctly which makes it try to use C++11

I also updated the ECs to use build_shared_libs = True instead of configopts = '-DBUILD_SHARED_LIBS=ON ' which is equivalent but cleaner.

The commit that introduced that new Abseil feature is abseil/abseil-cpp@ee0ebda i.e. version 20211102.0 but I still added the build_shared_libs-change to the older ECs so they are consistent

@Flamefire Flamefire marked this pull request as draft July 28, 2023 12:47
@Flamefire Flamefire marked this pull request as ready for review July 31, 2023 07:42
@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 20 out of 20 (4 easyconfigs in total)
taurusml4 - Linux RHEL 7.6, POWER, 8335-GTX (power9le), 6 x NVIDIA Tesla V100-SXM2-32GB, 440.64.00, Python 2.7.5
See https://gist.github.com/Flamefire/b43e7923ce9afd01719e203720721a76 for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=18413 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18413 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11328

Test results coming soon (I hope)...

Details

- notification for comment with ID 1658721794 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/3255d1c387f6d644dd4dcdad500676e9 for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
tcn363.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/dc5094c67c730b56f9f061bcb39df7f2 for a full test report.

Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just let me know if that configopts = '-DABSL_PROPAGATE_CXX_STD=ON ' was left out on purpose for Abseil-20210324. Looks fine otherwise, so after that option has been checked, this can be merged.

@casparvl casparvl added this to the next release (4.8.1?) milestone Aug 1, 2023
@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Aug 1, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18413 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18413 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3046

Test results coming soon (I hope)...

Details

- notification for comment with ID 1659846473 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/ddf139336456c7a18b755706d43c6123 for a full test report.

Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Aug 1, 2023

Going in, thanks @Flamefire!

@casparvl casparvl merged commit 73cfc87 into easybuilders:develop Aug 1, 2023
@Flamefire Flamefire deleted the 20230728142131_new_pr_Abseil202103242 branch August 1, 2023 09:35
@boegel boegel added the bug fix label Aug 2, 2023
@boegel boegel changed the title Fix CMake configs of Abseil add -DABSL_PROPAGATE_CXX_STD=ON to recent Abseil easyconfigs (required for PyTorch) Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants