add -DABSL_PROPAGATE_CXX_STD=ON to recent Abseil easyconfigs (required for PyTorch)#18413
Conversation
|
Test report by @Flamefire |
|
@boegelbot please test @ generoso |
|
@casparvl: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 1658721794 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @casparvl |
|
@boegelbot please test @ jsc-zen2 |
|
@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 1659846473 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Going in, thanks @Flamefire! |
-DABSL_PROPAGATE_CXX_STD=ON to recent Abseil easyconfigs (required for PyTorch)
(created using
eb --new-pr)This is required for e.g. PyTorch which otherwise fails to build with GCC 12 as the C++ standard flag isn't set correctly which makes it try to use C++11
I also updated the ECs to use
build_shared_libs = Trueinstead ofconfigopts = '-DBUILD_SHARED_LIBS=ON 'which is equivalent but cleaner.The commit that introduced that new Abseil feature is abseil/abseil-cpp@ee0ebda i.e. version 20211102.0 but I still added the build_shared_libs-change to the older ECs so they are consistent