add patch to fix flaky test optim test in PyTorch 1.12.1 w/ foss/2022a + CUDA 11.7.0#17726
Conversation
|
Test report by @Micket |
|
@VRehnberg Should we also add this patch to the other easyconfigs for PyTorch 1.12.1? |
|
I see no reason not to. Lets merge this first, it takes a million billion years for the test reports as usual |
I agree. This is changing one test, so I am happy with the one successful test report. I'll follow up with PRs for the other easyconfigs. |
|
Going in, thanks @VRehnberg! |
I agree that doing that in a single PR would have been bloody painful w.r.t. testing, that's not was I was suggesting. Doing it in separate PRs like @branfosj is the other extreme, but it doesn't hurt either. Good for PR stats, that's for sure. ;P |
|
See #17737 - this change looks to be causing issues with other tests in test optim. |
(created using
eb --new-pr)